| Message ID | Y6KfFEChA67E7oX/@VM-66-53-centos (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 | expand |
On 21/12/2022 06:52, Yuteng Zhong wrote: > from: DHDAXCW <lasstp5011@gmail.com> > > LubanCat 1 is a Rockchip RK3566 SBC based > is developed by EmbedFire Electronics Co., Ltd. > Mini Linux Card Type Cheap Computer Development Board This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 88ff4422a8c1..84d39a3a8843 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -781,6 +781,11 @@ properties: > - const: rockchip,rk3568-bpi-r2pro > - const: rockchip,rk3568 > > + - description: EmbedFire LubanCat 1 > + items: > + - const: embedfire,lubancat-1 > + - const: rockchip,rk3566 Here as well. Best regards, Krzysztof
Dear Kozlowski, Sorry that we didn't fully get the idea in your previous comments. > > On 21/12/2022 06:52, Yuteng Zhong wrote: > > from: DHDAXCW <lasstp5011@gmail.com> > > > > LubanCat 1 is a Rockchip RK3566 SBC based > > is developed by EmbedFire Electronics Co., Ltd. > > Mini Linux Card Type Cheap Computer Development Board > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. Your pervious comment were: > Please wrap commit message according to Linux coding style / submission > process: > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 So I think there must be something wrong in the message but I didn't notice. This message has a `from` line, and the body was wrapped at 75 columns. Please help me make it better. > > > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> > > Signed-off-by: DHDAXCW <lasstp5011@gmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 88ff4422a8c1..84d39a3a8843 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -781,6 +781,11 @@ properties: > > - const: rockchip,rk3568-bpi-r2pro > > - const: rockchip,rk3568 > > > > + - description: EmbedFire LubanCat 1 > > + items: > > + - const: embedfire,lubancat-1 > > + - const: rockchip,rk3566 > > Here as well. This change was addressing the previous comment in V2: > This is separate patch. Does not look like properly ordered. Don't add > stuff at the end of files/lists. The previous PATCH v2 merged changes in 3 diffent files: 1. arch/arm64/boot/dts/rockchip/Makefile 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts 3. Documentation/devicetree/bindings/arm/rockchip.yaml What we do in this PATCH v4 was separated the 3 into a separated patch.
On 21/12/2022 11:46, ty wrote: > Dear Kozlowski, > > Sorry that we didn't fully get the idea in your previous comments. > >> >> On 21/12/2022 06:52, Yuteng Zhong wrote: >>> from: DHDAXCW <lasstp5011@gmail.com> >>> >>> LubanCat 1 is a Rockchip RK3566 SBC based >>> is developed by EmbedFire Electronics Co., Ltd. >>> Mini Linux Card Type Cheap Computer Development Board >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. > > Your pervious comment were: > >> Please wrap commit message according to Linux coding style / submission >> process: >> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > So I think there must be something wrong in the message but I didn't > notice. This message has a `from` line, and the body was wrapped at 75 > columns. Please help me make it better. You do not wrap at 75, but at some other place. Just put it to editor and check where is wrapping (count characters). > > > >>> >>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> >>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com> >>> --- >>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> index 88ff4422a8c1..84d39a3a8843 100644 >>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> @@ -781,6 +781,11 @@ properties: >>> - const: rockchip,rk3568-bpi-r2pro >>> - const: rockchip,rk3568 >>> >>> + - description: EmbedFire LubanCat 1 >>> + items: >>> + - const: embedfire,lubancat-1 >>> + - const: rockchip,rk3566 >> >> Here as well. > > This change was addressing the previous comment in V2: > >> This is separate patch. Does not look like properly ordered. Don't add >> stuff at the end of files/lists. > > The previous PATCH v2 merged changes in 3 diffent files: > > 1. arch/arm64/boot/dts/rockchip/Makefile > 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > 3. Documentation/devicetree/bindings/arm/rockchip.yaml > > What we do in this PATCH v4 was separated the 3 into a separated patch. So how did you solve the comment "Does not look like properly ordered. Don't add stuff at the end of files/lists."? What did you change to solve it? Best regards, Krzysztof
Am Mittwoch, 21. Dezember 2022, 11:46:36 CET schrieb ty: > Dear Kozlowski, > > Sorry that we didn't fully get the idea in your previous comments. > > > > > On 21/12/2022 06:52, Yuteng Zhong wrote: > > > from: DHDAXCW <lasstp5011@gmail.com> > > > > > > LubanCat 1 is a Rockchip RK3566 SBC based > > > is developed by EmbedFire Electronics Co., Ltd. > > > Mini Linux Card Type Cheap Computer Development Board > > > > This is a friendly reminder during the review process. > > > > It seems my previous comments were not fully addressed. Maybe my > > feedback got lost between the quotes, maybe you just forgot to apply it. > > Please go back to the previous discussion and either implement all > > requested changes or keep discussing them. > > > > Thank you. > > Your pervious comment were: > > > Please wrap commit message according to Linux coding style / submission > > process: > > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > So I think there must be something wrong in the message but I didn't > notice. This message has a `from` line, and the body was wrapped at 75 > columns. Please help me make it better. > > > > > > > > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> > > > Signed-off-by: DHDAXCW <lasstp5011@gmail.com> > > > --- > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > index 88ff4422a8c1..84d39a3a8843 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > @@ -781,6 +781,11 @@ properties: > > > - const: rockchip,rk3568-bpi-r2pro > > > - const: rockchip,rk3568 > > > > > > + - description: EmbedFire LubanCat 1 > > > + items: > > > + - const: embedfire,lubancat-1 > > > + - const: rockchip,rk3566 > > > > Here as well. > > This change was addressing the previous comment in V2: > > > This is separate patch. Does not look like properly ordered. Don't add > > stuff at the end of files/lists. for context sorting order in that file is alphabetical by description Heiko
Hi, Kozlowski and Stübner, Thank you very much for pointing me in the right direction. > So how did you solve the comment "Does not look like properly ordered. > Don't add stuff at the end of files/lists."? What did you change to > solve it? > for context sorting order in that file is alphabetical by description I finally got it. It should be put right after the "Elgin RV1108 R1". > You do not wrap at 75, but at some other place. Just put it to editor > and check where is wrapping (count characters). The original message was: > from: DHDAXCW <lasstp5011@gmail.com> > > LubanCat 1 is a Rockchip RK3566 SBC based > is developed by EmbedFire Electronics Co., Ltd. > Mini Linux Card Type Cheap Computer Development Board > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com> The longest line is "Mini Linux Card Type Cheap Computer Development Board", which has 53 characters. Or ... I should use the whole line as much as possible? Then I see why I was doing wrong. It will be fixed in the PATCH v5.
On 21/12/2022 13:12, ty wrote: > Hi, Kozlowski and Stübner, > > Thank you very much for pointing me in the right direction. > >> So how did you solve the comment "Does not look like properly ordered. >> Don't add stuff at the end of files/lists."? What did you change to >> solve it? > >> for context sorting order in that file is alphabetical by description > > I finally got it. It should be put right after the "Elgin RV1108 R1". > >> You do not wrap at 75, but at some other place. Just put it to editor >> and check where is wrapping (count characters). > > The original message was: > >> from: DHDAXCW <lasstp5011@gmail.com> >> >> LubanCat 1 is a Rockchip RK3566 SBC based >> is developed by EmbedFire Electronics Co., Ltd. >> Mini Linux Card Type Cheap Computer Development Board >> >> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com> >> Signed-off-by: DHDAXCW <lasstp5011@gmail.com> > > The longest line is "Mini Linux Card Type Cheap Computer Development > Board", which has 53 characters. Or ... I should use the whole line as > much as possible? Then I see why I was doing wrong. It will be fixed > in the PATCH v5. Yes, because such commit msg is also within 75 characters but it is not correct, right? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 88ff4422a8c1..84d39a3a8843 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -781,6 +781,11 @@ properties: - const: rockchip,rk3568-bpi-r2pro - const: rockchip,rk3568 + - description: EmbedFire LubanCat 1 + items: + - const: embedfire,lubancat-1 + - const: rockchip,rk3566 + additionalProperties: true ...