| Message ID | 1671618061-6329-2-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add resets for ADSP based audio clock controller driver. | expand |
On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote: > Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks > for audioreach based SC7280 platforms. Use subject prefixes matching the subsystem (git log --oneline -- ...). The final prefix should be "qcom,sc7280-lpasscc" and then the actual subject should drop redundant pieces. > ... Best regards, Krzysztof
On 12/21/2022 4:12 PM, Krzysztof Kozlowski wrote: Thanks for your time Krzyszto!!! > On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote: >> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks >> for audioreach based SC7280 platforms. > Use subject prefixes matching the subsystem (git log --oneline -- ...). > The final prefix should be "qcom,sc7280-lpasscc" and then the actual > subject should drop redundant pieces. Sorry. I didn't understand much from your statement. Do you mean subject should something like below? dt-bindings: clock: qcom: sc7280-lpasscc: Add resets for audio clock controller > >> ... > Best regards, > Krzysztof >
On 21/12/2022 13:22, Srinivasa Rao Mandadapu wrote: > > On 12/21/2022 4:12 PM, Krzysztof Kozlowski wrote: > Thanks for your time Krzyszto!!! >> On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote: >>> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks >>> for audioreach based SC7280 platforms. >> Use subject prefixes matching the subsystem (git log --oneline -- ...). >> The final prefix should be "qcom,sc7280-lpasscc" and then the actual ^^^^^^^ it's written here >> subject should drop redundant pieces. > > Sorry. I didn't understand much from your statement. > > Do you mean subject should something like below? > > dt-bindings: clock: qcom: sc7280-lpasscc: Add resets for audio clock > controller 1. The last prefix should be "qcom,sc7280-lpasscc:". 2. And then drop "audio clock controller" because it is obvious, isn't it? > >> >>> ... >> Best regards, >> Krzysztof >> Best regards, Krzysztof
On 12/21/2022 5:54 PM, Krzysztof Kozlowski wrote: > On 21/12/2022 13:22, Srinivasa Rao Mandadapu wrote: >> On 12/21/2022 4:12 PM, Krzysztof Kozlowski wrote: >> Thanks for your time Krzyszto!!! >>> On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote: >>>> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks >>>> for audioreach based SC7280 platforms. >>> Use subject prefixes matching the subsystem (git log --oneline -- ...). >>> The final prefix should be "qcom,sc7280-lpasscc" and then the actual > ^^^^^^^ it's written here > >>> subject should drop redundant pieces. >> Sorry. I didn't understand much from your statement. >> >> Do you mean subject should something like below? >> >> dt-bindings: clock: qcom: sc7280-lpasscc: Add resets for audio clock >> controller > 1. The last prefix should be "qcom,sc7280-lpasscc:". > 2. And then drop "audio clock controller" because it is obvious, isn't it? Okay!. Thanks for clarifying. I will change accordingly. Actually I followed previous similar commits. > >>>> ... >>> Best regards, >>> Krzysztof >>> > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml index 6151fde..b9be5f1 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml @@ -31,6 +31,9 @@ properties: '#clock-cells': const: 1 + '#reset-cells': + const: 1 + reg: items: - description: LPASS qdsp6ss register @@ -61,5 +64,6 @@ examples: clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>; clock-names = "iface"; #clock-cells = <1>; + #reset-cells = <1>; }; ...
Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks for audioreach based SC7280 platforms. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> --- Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml | 4 ++++ 1 file changed, 4 insertions(+)