| Message ID | 20221214205147.2172-1-aldas60@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | staging: qlge: remove unnecessary spaces before function pointer args | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Wed, Dec 14, 2022 at 10:51:47PM +0200, Aldas Taraškevičius wrote: > Remove unnecessary spaces before the function pointer arguments as > warned by checkpatch. > > Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> > --- > drivers/staging/qlge/qlge.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index fc8c5ca89..05e4f4744 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2057,8 +2057,8 @@ enum { > }; > > struct nic_operations { > - int (*get_flash) (struct ql_adapter *); > - int (*port_initialize) (struct ql_adapter *); > + int (*get_flash)(struct ql_adapter *); > + int (*port_initialize)(struct ql_adapter *); > }; I'm not clear if there is consensus on the style issue at play here. And so I am neutral on this patch. But perhaps if these lines are being updated then the following check patch warnings could be addressed. $ scripts/checkpatch.pl --strict this.patch WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name #122: FILE: drivers/staging/qlge/qlge.h:2060: + int (*get_flash)(struct ql_adapter *); WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name #123: FILE: drivers/staging/qlge/qlge.h:2061: + int (*port_initialize)(struct ql_adapter *); total: 0 errors, 2 warnings, 0 checks, 10 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] staging: qlge: remove unnecessary spaces before function pointer args" has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
On Wed, Dec 14, 2022 at 10:51:47PM +0200, Aldas Taraškevičius wrote: > Remove unnecessary spaces before the function pointer arguments as > warned by checkpatch. > > Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> > --- > drivers/staging/qlge/qlge.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index fc8c5ca89..05e4f4744 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2057,8 +2057,8 @@ enum { > }; > > struct nic_operations { > - int (*get_flash) (struct ql_adapter *); > - int (*port_initialize) (struct ql_adapter *); > + int (*get_flash)(struct ql_adapter *); > + int (*port_initialize)(struct ql_adapter *); > }; > > /* > -- > 2.37.2 > > Does not apply to my tree :(
diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index fc8c5ca89..05e4f4744 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2057,8 +2057,8 @@ enum { }; struct nic_operations { - int (*get_flash) (struct ql_adapter *); - int (*port_initialize) (struct ql_adapter *); + int (*get_flash)(struct ql_adapter *); + int (*port_initialize)(struct ql_adapter *); }; /*
Remove unnecessary spaces before the function pointer arguments as warned by checkpatch. Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> --- drivers/staging/qlge/qlge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)