diff mbox series

[v5,2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Message ID Y6MQ2b8JyST6fPVE@VM-66-53-centos (mailing list archive)
State New, archived
Headers show
Series [v5,1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 | expand

Commit Message

ty Dec. 21, 2022, 1:57 p.m. UTC 
From: DHDAXCW <lasstp5011@gmail.com>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Dec. 21, 2022, 3:06 p.m. UTC | #1 
On 21/12/2022 14:57, Yuteng Zhong wrote:
> From: DHDAXCW <lasstp5011@gmail.com>
> 
> Add devicetree binding documentation for the EmbedFire LubanCat 1.
> 
> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> ---

Thanks for the changes. The SoB chain is not correct - wrong order.
"DHDAXCW" does not look person's name and we need real names.

Best regards,
Krzysztof
ty Dec. 21, 2022, 3:15 p.m. UTC | #2 
Got it. So the two SoB lines should be swapped? They should be changed to:

Signed-off-by: Wenhao Cui <lasstp5011@gmail.com>
Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2022年12月21日周三 23:06写道：
>
> On 21/12/2022 14:57, Yuteng Zhong wrote:
> > From: DHDAXCW <lasstp5011@gmail.com>
> >
> > Add devicetree binding documentation for the EmbedFire LubanCat 1.
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> > ---
>
> Thanks for the changes. The SoB chain is not correct - wrong order.
> "DHDAXCW" does not look person's name and we need real names.
>
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Dec. 21, 2022, 3:18 p.m. UTC | #3 
On 21/12/2022 16:15, ty wrote:
> Got it. So the two SoB lines should be swapped? They should be changed to:
> 
> Signed-off-by: Wenhao Cui <lasstp5011@gmail.com>
> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>

Yes.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 88ff4422a8c1..058ed707f3cd 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -95,6 +95,11 @@  properties:
           - const: elgin,rv1108-r1
           - const: rockchip,rv1108
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566
+
       - description: Engicam PX30.Core C.TOUCH 2.0
         items:
           - const: engicam,px30-core-ctouch2