| Message ID | 20221222151319.122398-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v4,1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name | expand |
On 22.12.2022 16:13, Krzysztof Kozlowski wrote: > The pin config entry should have a string, not number, for the GPIO used > as WCD9340 audio codec interrupt. > > Fixes: 89a32a4e769c ("arm64: dts: qcom: db845c: add analog audio support") > Reported-by: Doug Anderson <dianders@chromium.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Cc: Doug Anderson <dianders@chromium.org> > > Changes since v3: > 1. Add Fixes and Rb tags. > > Changes since v2: > 1. New patch. > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index f41c6d600ea8..774e4352f299 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -979,7 +979,7 @@ sdc2_card_det_n: sd-card-det-n { > }; > > wcd_intr_default: wcd_intr_default { > - pins = <54>; > + pins = "gpio54"; > function = "gpio"; > > input-enable;
On Thu, 22 Dec 2022 16:13:16 +0100, Krzysztof Kozlowski wrote: > The pin config entry should have a string, not number, for the GPIO used > as WCD9340 audio codec interrupt. > > Applied, thanks! [1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name commit: 740862bb5f59b93efb390a417995f88a64bdc323 [2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix audio codec interrupt pin name commit: e5011447376e1b050847ccb2ef7933176ce4de41 [3/4] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema commit: d05e342882e4fb2ccd8e4b6af00b0b82e22ad325 [4/4] arm64: dts: qcom: sdm845: do not customize SPI0 pin drive/bias commit: 0cbc0b1c5838b02c67a768392bb34732f0d384b0 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index f41c6d600ea8..774e4352f299 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -979,7 +979,7 @@ sdc2_card_det_n: sd-card-det-n { }; wcd_intr_default: wcd_intr_default { - pins = <54>; + pins = "gpio54"; function = "gpio"; input-enable;
The pin config entry should have a string, not number, for the GPIO used as WCD9340 audio codec interrupt. Fixes: 89a32a4e769c ("arm64: dts: qcom: db845c: add analog audio support") Reported-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- Cc: Doug Anderson <dianders@chromium.org> Changes since v3: 1. Add Fixes and Rb tags. Changes since v2: 1. New patch. --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)