[v9,2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Commit Message

ty Dec. 23, 2022, 3:17 a.m. UTC

From: Wenhao Cui <[e-mail]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

Signed-off-by: Wenhao Cui <[e-mail]>
Signed-off-by: Yuteng Zhong <[e-mail]>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Dec. 23, 2022, 8:01 a.m. UTC | #1

On 23/12/2022 04:17, Yuteng Zhong wrote:
> From: Wenhao Cui <[e-mail]>
> 
> Add devicetree binding documentation for the EmbedFire LubanCat 1.
> 
> Signed-off-by: Wenhao Cui <[e-mail]>
> Signed-off-by: Yuteng Zhong <[e-mail]>
> ---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Best regards,
Krzysztof

ty Dec. 23, 2022, 9:42 a.m. UTC | #2

Hi, Krzysztof,

Sorry, we do not know the process, this is our first contribution to
the Linux Kernel. There is no change since the last review of this
file.

Krzysztof Kozlowski <[e-mail]> 于2022年12月23日周五 16:01写道：
>
> On 23/12/2022 04:17, Yuteng Zhong wrote:
> > From: Wenhao Cui <[e-mail]>
> >
> > Add devicetree binding documentation for the EmbedFire LubanCat 1.
> >
> > Signed-off-by: Wenhao Cui <[e-mail]>
> > Signed-off-by: Yuteng Zhong <[e-mail]>
> > ---
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
>
>
> Best regards,
> Krzysztof
>

Krzysztof Kozlowski Dec. 23, 2022, 10:18 a.m. UTC | #3

On 23/12/2022 10:42, ty wrote:
> Hi, Krzysztof,
> 
> Sorry, we do not know the process, this is our first contribution to
> the Linux Kernel. There is no change since the last review of this
> file.

So I linked you the process and explain it.


Best regards,
Krzysztof

ty Dec. 23, 2022, 10:56 a.m. UTC | #4

Got it. 2/3 and 3/3 will have the Acked-By line in the next PATCH version.

May I ask whether there are any changes required in [PATCH v9 1/3]?

Krzysztof Kozlowski <[e-mail]> 于2022年12月23日周五 18:18写道：
>
> On 23/12/2022 10:42, ty wrote:
> > Hi, Krzysztof,
> >
> > Sorry, we do not know the process, this is our first contribution to
> > the Linux Kernel. There is no change since the last review of this
> > file.
>
> So I linked you the process and explain it.
>
>
> Best regards,
> Krzysztof
>

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 88ff4422a8c1..058ed707f3cd 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -95,6 +95,11 @@  properties:
           - const: elgin,rv1108-r1
           - const: rockchip,rv1108
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566
+
       - description: Engicam PX30.Core C.TOUCH 2.0
         items:
           - const: engicam,px30-core-ctouch2