| Message ID | 20221223132235.16149-1-anand@edgeble.ai (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PATCHv1,linux-next,1/4] dt-bindings: net: rockchip-dwmac: fix rv1126 compatible warning | expand |
On 23/12/2022 14:22, Anand Moon wrote: > Fix compatible string for RV1126 gmac, and constrain it to > be compatible with Synopsys dwmac 4.20a. > > fix below warning > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000: > compatible: 'oneOf' conditional failed, one must be fixed: > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac'] > > Signed-off-by: Anand Moon <anand@edgeble.ai> > Signed-off-by: Jagan Teki <jagan@edgeble.ai> This SoB order is a bit unexpected - who is the author and who is sending it? Best regards, Krzysztof
On Fri, 23 Dec 2022 at 18:55, Anand Moon <anand@edgeble.ai> wrote: > > Fix compatible string for RV1126 gmac, and constrain it to > be compatible with Synopsys dwmac 4.20a. > > fix below warning > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000: > compatible: 'oneOf' conditional failed, one must be fixed: > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac'] > > Signed-off-by: Anand Moon <anand@edgeble.ai> > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > --- Please add Fixes above SoB.
On Sat, Dec 24, 2022 at 9:30 AM Jagan Teki <jagan@edgeble.ai> wrote: > > On Fri, 23 Dec 2022 at 18:55, Anand Moon <anand@edgeble.ai> wrote: > > > > Fix compatible string for RV1126 gmac, and constrain it to > > be compatible with Synopsys dwmac 4.20a. > > > > fix below warning > > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000: > > compatible: 'oneOf' conditional failed, one must be fixed: > > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long > > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac'] > > > > Signed-off-by: Anand Moon <anand@edgeble.ai> > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > --- > > Please add Fixes above SoB. That and, shouldn't the Signed-off-by: tags be reversed if Anand is sending this? Confused, -- Slade
On Sun, 25 Dec 2022 at 02:54, Slade Watkins <srw@sladewatkins.net> wrote: > > On Sat, Dec 24, 2022 at 9:30 AM Jagan Teki <jagan@edgeble.ai> wrote: > > > > On Fri, 23 Dec 2022 at 18:55, Anand Moon <anand@edgeble.ai> wrote: > > > > > > Fix compatible string for RV1126 gmac, and constrain it to > > > be compatible with Synopsys dwmac 4.20a. > > > > > > fix below warning > > > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000: > > > compatible: 'oneOf' conditional failed, one must be fixed: > > > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long > > > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac'] > > > > > > Signed-off-by: Anand Moon <anand@edgeble.ai> > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > --- > > > > Please add Fixes above SoB. > > That and, shouldn't the Signed-off-by: tags be reversed if Anand is > sending this? Agreed, Anand will resend the patch with SoB removed. thanks. Jagan.
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 42fb72b6909d..04936632fcbb 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -49,11 +49,11 @@ properties: - rockchip,rk3368-gmac - rockchip,rk3399-gmac - rockchip,rv1108-gmac - - rockchip,rv1126-gmac - items: - enum: - rockchip,rk3568-gmac - rockchip,rk3588-gmac + - rockchip,rv1126-gmac - const: snps,dwmac-4.20a clocks:
Fix compatible string for RV1126 gmac, and constrain it to be compatible with Synopsys dwmac 4.20a. fix below warning arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac'] Signed-off-by: Anand Moon <anand@edgeble.ai> Signed-off-by: Jagan Teki <jagan@edgeble.ai> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)