| Message ID | 20221231222420.75233-6-they@mint.lgbt (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v5,1/6] dt-bindings: ufs: qcom: Add SM6125 compatible string | expand |
On Sat, Dec 31 2022 at 07:24:19 PM -03:00:00, Lux Aliaga <they@mint.lgbt> wrote: > Document the Xiaomi Mi A3 (xiaomi-laurel-sprout) smartphone which is > based on the Snapdragon 665 SoC. > > Signed-off-by: Lux Aliaga <they@mint.lgbt> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml > b/Documentation/devicetree/bindings/arm/qcom.yaml > index 27063a045bd0..4923dafb5d7a 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -793,6 +793,7 @@ properties: > - items: > - enum: > - sony,pdx201 > + - xiaomi,laurel-sprout From what i can see laurel_sprout is the correct and official codename for the device. Not sure here at all but should we maybe use that as it is the official codename ? -Martin > - const: qcom,sm6125 > > - items: > -- > 2.38.1 >
On 31/12/2022 23:24, Lux Aliaga wrote: > Document the Xiaomi Mi A3 (xiaomi-laurel-sprout) smartphone which is > based on the Snapdragon 665 SoC. > > Signed-off-by: Lux Aliaga <they@mint.lgbt> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On 31/12/2022 19:50, Martin Botka wrote: > > > On Sat, Dec 31 2022 at 07:24:19 PM -03:00:00, Lux Aliaga > <they@mint.lgbt> wrote: >> Document the Xiaomi Mi A3 (xiaomi-laurel-sprout) smartphone which is >> based on the Snapdragon 665 SoC. >> >> Signed-off-by: Lux Aliaga <they@mint.lgbt> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml >> b/Documentation/devicetree/bindings/arm/qcom.yaml >> index 27063a045bd0..4923dafb5d7a 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -793,6 +793,7 @@ properties: >> - items: >> - enum: >> - sony,pdx201 >> + - xiaomi,laurel-sprout > From what i can see laurel_sprout is the correct and official codename > for the device. > > Not sure here at all but should we maybe use that as it is the > official codename ? > > -Martin I defined it as shown due to the following comment. https://lore.kernel.org/linux-devicetree/c4bf26a4-16bb-6ed8-ae70-1947998e32cc@linaro.org/
On 01/01/2023 12:40, Krzysztof Kozlowski wrote: > On 31/12/2022 23:24, Lux Aliaga wrote: >> Document the Xiaomi Mi A3 (xiaomi-laurel-sprout) smartphone which is >> based on the Snapdragon 665 SoC. >> >> Signed-off-by: Lux Aliaga <they@mint.lgbt> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions. However, there's no need to repost patches *only* to add the > tags. The upstream maintainer will do that for acks received on the > version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. > > > > > Best regards, > Krzysztof This was accidental. I've already fixed it so in the next revision these changes get applied. My apologies.
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 27063a045bd0..4923dafb5d7a 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -793,6 +793,7 @@ properties: - items: - enum: - sony,pdx201 + - xiaomi,laurel-sprout - const: qcom,sm6125 - items:
Document the Xiaomi Mi A3 (xiaomi-laurel-sprout) smartphone which is based on the Snapdragon 665 SoC. Signed-off-by: Lux Aliaga <they@mint.lgbt> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)