| Message ID | 20221222191641.1643117-3-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | A few bugfix and cleancode patch for bfq | expand |
On Fri 23-12-22 03:16:33, Kemeng Shi wrote: > Parameter reason is never used, just remove it. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 1220c41fc767..5a6d9e8c329d 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -4066,8 +4066,7 @@ static void __bfq_bfqq_recalc_budget(struct bfq_data *bfqd, > * function to evaluate the I/O speed of a process. > */ > static bool bfq_bfqq_is_slow(struct bfq_data *bfqd, struct bfq_queue *bfqq, > - bool compensate, enum bfqq_expiration reason, > - unsigned long *delta_ms) > + bool compensate, unsigned long *delta_ms) > { > ktime_t delta_ktime; > u32 delta_usecs; > @@ -4263,7 +4262,7 @@ void bfq_bfqq_expire(struct bfq_data *bfqd, > /* > * Check whether the process is slow (see bfq_bfqq_is_slow). > */ > - slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, reason, &delta); > + slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, &delta); > > /* > * As above explained, charge slow (typically seeky) and > -- > 2.30.0 >
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 1220c41fc767..5a6d9e8c329d 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4066,8 +4066,7 @@ static void __bfq_bfqq_recalc_budget(struct bfq_data *bfqd, * function to evaluate the I/O speed of a process. */ static bool bfq_bfqq_is_slow(struct bfq_data *bfqd, struct bfq_queue *bfqq, - bool compensate, enum bfqq_expiration reason, - unsigned long *delta_ms) + bool compensate, unsigned long *delta_ms) { ktime_t delta_ktime; u32 delta_usecs; @@ -4263,7 +4262,7 @@ void bfq_bfqq_expire(struct bfq_data *bfqd, /* * Check whether the process is slow (see bfq_bfqq_is_slow). */ - slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, reason, &delta); + slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, &delta); /* * As above explained, charge slow (typically seeky) and
Parameter reason is never used, just remove it. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/bfq-iosched.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)