| Message ID | 20221228092045.80425-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpiolib: eventual of_node retirement | expand |
On Wed, Dec 28, 2022 at 10:20 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Now that all GPIO library users are converted to use fwnode, > Drop redundant field from struct gpio_chip and accompanying > code. This is great stuff. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Dec 28, 2022 at 10:20 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Now that all GPIO library users are converted to use fwnode, > Drop redundant field from struct gpio_chip and accompanying > code. > > Bart, I prefer this series to go as soon as possible if you > have no objection. Or even as v6.2 material. > > Thierry, can you please test it once again, so we will be sure > there is no breakage for OF platforms? > > Cc: Thierry Reding <treding@nvidia.com> > > v4: added couple of additional patches to the bundle that missed > the merge window by one or another reason > > v3: rebased against latest Linux Next: expected not to fail now > (Also keeping in mind Thierry's report, so reworked a bit) > > v2: resent against latest Linux Next: expected not to fail now > (Linux Next has no more users of of_node member of gpio_chip) > > v1: to test for now (using CIs and build bots) what is left unconverted > (Expected to fail in some configurations!) > > Andy Shevchenko (3): > gpiolib: Introduce gpio_device_get() and gpio_device_put() > gpiolib: Get rid of not used of_node member > gpiolib: sort header inclusion alphabetically > > drivers/gpio/gpiolib-acpi.c | 10 ------- > drivers/gpio/gpiolib-acpi.h | 4 --- > drivers/gpio/gpiolib-cdev.c | 21 ++++++------- > drivers/gpio/gpiolib-of.c | 25 ++++------------ > drivers/gpio/gpiolib-of.h | 5 ---- > drivers/gpio/gpiolib.c | 60 +++++++++++++++++-------------------- > drivers/gpio/gpiolib.h | 10 +++++++ > include/linux/gpio/driver.h | 7 ----- > 8 files changed, 51 insertions(+), 91 deletions(-) > > > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 > -- > 2.35.1 > I applied the series, let's give it some time in next and see that nothing breaks. Bart
On Wed, Dec 28, 2022 at 11:20:42AM +0200, Andy Shevchenko wrote: > Now that all GPIO library users are converted to use fwnode, > Drop redundant field from struct gpio_chip and accompanying > code. > > Bart, I prefer this series to go as soon as possible if you > have no objection. Or even as v6.2 material. > > Thierry, can you please test it once again, so we will be sure > there is no breakage for OF platforms? Seems to be working fine on at least Jetson TX1, so: Tested-by: Thierry Reding <treding@nvidia.com>
On Wed, Jan 04, 2023 at 05:41:46PM +0100, Thierry Reding wrote: > On Wed, Dec 28, 2022 at 11:20:42AM +0200, Andy Shevchenko wrote: > > Now that all GPIO library users are converted to use fwnode, > > Drop redundant field from struct gpio_chip and accompanying > > code. > > > > Bart, I prefer this series to go as soon as possible if you > > have no objection. Or even as v6.2 material. > > > > Thierry, can you please test it once again, so we will be sure > > there is no breakage for OF platforms? > > Seems to be working fine on at least Jetson TX1, so: > > Tested-by: Thierry Reding <treding@nvidia.com> Thank you and HNY!
On Wed, Jan 04, 2023 at 06:51:24PM +0200, Andy Shevchenko wrote: > On Wed, Jan 04, 2023 at 05:41:46PM +0100, Thierry Reding wrote: > > On Wed, Dec 28, 2022 at 11:20:42AM +0200, Andy Shevchenko wrote: > > > Now that all GPIO library users are converted to use fwnode, > > > Drop redundant field from struct gpio_chip and accompanying > > > code. > > > > > > Bart, I prefer this series to go as soon as possible if you > > > have no objection. Or even as v6.2 material. > > > > > > Thierry, can you please test it once again, so we will be sure > > > there is no breakage for OF platforms? > > > > Seems to be working fine on at least Jetson TX1, so: > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > Thank you and HNY! Happy New Year! Thierry
Now that all GPIO library users are converted to use fwnode, Drop redundant field from struct gpio_chip and accompanying code. Bart, I prefer this series to go as soon as possible if you have no objection. Or even as v6.2 material. Thierry, can you please test it once again, so we will be sure there is no breakage for OF platforms? Cc: Thierry Reding <treding@nvidia.com> v4: added couple of additional patches to the bundle that missed the merge window by one or another reason v3: rebased against latest Linux Next: expected not to fail now (Also keeping in mind Thierry's report, so reworked a bit) v2: resent against latest Linux Next: expected not to fail now (Linux Next has no more users of of_node member of gpio_chip) v1: to test for now (using CIs and build bots) what is left unconverted (Expected to fail in some configurations!) Andy Shevchenko (3): gpiolib: Introduce gpio_device_get() and gpio_device_put() gpiolib: Get rid of not used of_node member gpiolib: sort header inclusion alphabetically drivers/gpio/gpiolib-acpi.c | 10 ------- drivers/gpio/gpiolib-acpi.h | 4 --- drivers/gpio/gpiolib-cdev.c | 21 ++++++------- drivers/gpio/gpiolib-of.c | 25 ++++------------ drivers/gpio/gpiolib-of.h | 5 ---- drivers/gpio/gpiolib.c | 60 +++++++++++++++++-------------------- drivers/gpio/gpiolib.h | 10 +++++++ include/linux/gpio/driver.h | 7 ----- 8 files changed, 51 insertions(+), 91 deletions(-) base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2