| Message ID | 20230104011524.369764-3-robbarnes@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 957445d730badbea1b3b2ef038e60d2ca38abd0a |
| Headers | show |
| Series | Handle CrOS EC Panics | expand |
On Tue, Jan 3, 2023 at 5:15 PM Rob Barnes <robbarnes@google.com> wrote: > > When an EC panic is reported, attempt an orderly shutdown. > Force a shutdown after a brief timeout if the orderly shutdown > fails for any reason. > > Using the common hw_protection_shutdown utility function since > an EC panic has the potential to cause hw damage. > > This is all best effort. EC should also force a hard reset after a > short timeout. > > Signed-off-by: Rob Barnes <robbarnes@google.com> FWIW: Reviewed-by: Prashant Malani <pmalani@chromium.org>
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 5738f1d25091..3708fa75feb1 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -21,6 +21,7 @@ #include <linux/platform_data/cros_ec_proto.h> #include <linux/platform_device.h> #include <linux/printk.h> +#include <linux/reboot.h> #include <linux/suspend.h> #include "cros_ec.h" @@ -323,6 +324,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data) if (value == ACPI_NOTIFY_CROS_EC_PANIC) { dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!"); blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev); + /* Begin orderly shutdown. Force shutdown after 1 second. */ + hw_protection_shutdown("CrOS EC Panic", 1000); /* Do not query for other events after a panic is reported */ return; }
When an EC panic is reported, attempt an orderly shutdown. Force a shutdown after a brief timeout if the orderly shutdown fails for any reason. Using the common hw_protection_shutdown utility function since an EC panic has the potential to cause hw damage. This is all best effort. EC should also force a hard reset after a short timeout. Signed-off-by: Rob Barnes <robbarnes@google.com> --- Changelog since v1: - Split into two patches drivers/platform/chrome/cros_ec_lpc.c | 3 +++ 1 file changed, 3 insertions(+)