diff mbox series

[V2,2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration

Message ID 20221226234751.444917-3-mjg59@srcf.ucam.org (mailing list archive)
State New, archived
Headers show
Series [V2,1/3] USB: serial: option: Add generic MDM9207 configurations | expand

Commit Message

Matthew Garrett Dec. 26, 2022, 11:47 p.m. UTC
The Orbic Speed RC400L presents as a generic MDM9207 device that supports
multiple configurations with different USB IDs. One exposes a QMI interface.
Add the ID for that.

Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjørn Mork Jan. 4, 2023, 7:53 p.m. UTC | #1
Matthew Garrett <mjg59@srcf.ucam.org> writes:

> The Orbic Speed RC400L presents as a generic MDM9207 device that supports
> multiple configurations with different USB IDs. One exposes a QMI interface.
> Add the ID for that.
>
> Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index a808d718c012..bf05b7feacc0 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1223,6 +1223,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)},    /* ublox R410M */
>  	{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
>  	{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
> +	{QMI_FIXED_INTF(0x05c6, 0xf601, 5)},
>  	{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)},	/* YUGA CLM920-NC5 */
>  	{QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
>  	{QMI_FIXED_INTF(0x0846, 0x68d3, 8)},	/* Netgear Aircard 779S */


Looks good to me, but checkpatch warns about

 WARNING: From:/Signed-off-by: email address mismatch: 'From: Matthew Garrett <mjg59@srcf.ucam.org>' != 'Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>'

which you might want to consider, unless this was intentional for some
reason?  In any case:

Acked-by: Bjørn Mork <bjorn@mork.no>
diff mbox series

Patch

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index a808d718c012..bf05b7feacc0 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1223,6 +1223,7 @@  static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)},    /* ublox R410M */
 	{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
 	{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
+	{QMI_FIXED_INTF(0x05c6, 0xf601, 5)},
 	{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)},	/* YUGA CLM920-NC5 */
 	{QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
 	{QMI_FIXED_INTF(0x0846, 0x68d3, 8)},	/* Netgear Aircard 779S */