diff mbox series

[XEN,v2,2/2] automation: add RISC-V 64 cross-build tests for Xen

Message ID 855e05a0459d44282679f08c8f67e38d35635eb6.1672401599.git.oleksii.kurochko@gmail.com (mailing list archive)
State Superseded
Headers show
Series Add minimal RISC-V Xen build and build testing | expand

Commit Message

Oleksii Kurochko Dec. 30, 2022, 1:01 p.m. UTC 
Add build jobs to cross-compile Xen-only for RISC-V 64.

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
---
Changes in V2:
- Add HYPERVISOR_ONLY to RISCV jobs because after rebase on
  top of the patch series "CI: Fixes/cleanup in preparation for RISCV"
  it is required to set HYPERVISOR_ONLY in build.yaml
---
 automation/gitlab-ci/build.yaml | 45 +++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

Comments

Andrew Cooper Jan. 4, 2023, 8:39 p.m. UTC | #1 
On 30/12/2022 1:01 pm, Oleksii Kurochko wrote:
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index e6a9357de3..11eb1c6b82 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -617,6 +644,21 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools:
>      EXTRA_XEN_CONFIG: |
>        CONFIG_BOOT_TIME_CPUPOOLS=y
>  
> +# RISC-V 64 cross-build
> +riscv64-cross-gcc:
> +  extends: .gcc-riscv64-cross-build
> +  variables:
> +    CONTAINER: archlinux:riscv64
> +    KBUILD_DEFCONFIG: tiny64_defconfig
> +    HYPERVISOR_ONLY: y
> +
> +riscv64-cross-gcc-debug:
> +  extends: .gcc-riscv64-cross-build-debug
> +  variables:
> +    CONTAINER: archlinux:riscv64
> +    KBUILD_DEFCONFIG: tiny64_defconfig
> +    HYPERVISOR_ONLY: y
> +

Judging by the Kconfig which gets written out, I suggest inserting the
two RANDCONFIG jobs right now.

>  ## Test artifacts common
>  
>  .test-jobs-artifact-common:
> @@ -692,3 +734,6 @@ kernel-5.10.74-export:
>        - binaries/bzImage
>    tags:
>      - x86_64
> +
> +# # RISC-V 64 test artificats
> +# # TODO: add RISC-V 64 test artitifacts

Drop this hunk.  All you're going to be doing is deleting it in the next
series...

~Andrew
Oleksii Kurochko Jan. 5, 2023, 12:07 p.m. UTC | #2 
On Wed, 2023-01-04 at 20:39 +0000, Andrew Cooper wrote:
> On 30/12/2022 1:01 pm, Oleksii Kurochko wrote:
> > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-
> > ci/build.yaml
> > index e6a9357de3..11eb1c6b82 100644
> > --- a/automation/gitlab-ci/build.yaml
> > +++ b/automation/gitlab-ci/build.yaml
> > @@ -617,6 +644,21 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools:
> >      EXTRA_XEN_CONFIG: |
> >        CONFIG_BOOT_TIME_CPUPOOLS=y
> >  
> > +# RISC-V 64 cross-build
> > +riscv64-cross-gcc:
> > +  extends: .gcc-riscv64-cross-build
> > +  variables:
> > +    CONTAINER: archlinux:riscv64
> > +    KBUILD_DEFCONFIG: tiny64_defconfig
> > +    HYPERVISOR_ONLY: y
> > +
> > +riscv64-cross-gcc-debug:
> > +  extends: .gcc-riscv64-cross-build-debug
> > +  variables:
> > +    CONTAINER: archlinux:riscv64
> > +    KBUILD_DEFCONFIG: tiny64_defconfig
> > +    HYPERVISOR_ONLY: y
> > +
> 
> Judging by the Kconfig which gets written out, I suggest inserting
> the
> two RANDCONFIG jobs right now.
> 
> >  ## Test artifacts common
> >  
> >  .test-jobs-artifact-common:
> > @@ -692,3 +734,6 @@ kernel-5.10.74-export:
> >        - binaries/bzImage
> >    tags:
> >      - x86_64
> > +
> > +# # RISC-V 64 test artificats
> > +# # TODO: add RISC-V 64 test artitifacts
> 
> Drop this hunk.  All you're going to be doing is deleting it in the
> next
> series...
> 

Thanks for the comments.
They were fixed in patch series v4:
[PATCH v4 2/2] automation: add RISC-V 64 cross-build tests for Xen

~ Oleksii
> ~Andrew
diff mbox series

Patch

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index e6a9357de3..11eb1c6b82 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -172,6 +172,33 @@ 
   variables:
     <<: *gcc
 
+.riscv64-cross-build-tmpl:
+  <<: *build
+  variables:
+    XEN_TARGET_ARCH: riscv64
+  tags:
+    - x86_64
+
+.riscv64-cross-build:
+  extends: .riscv64-cross-build-tmpl
+  variables:
+    debug: n
+
+.riscv64-cross-build-debug:
+  extends: .riscv64-cross-build-tmpl
+  variables:
+    debug: y
+
+.gcc-riscv64-cross-build:
+  extends: .riscv64-cross-build
+  variables:
+    <<: *gcc
+
+.gcc-riscv64-cross-build-debug:
+  extends: .riscv64-cross-build-debug
+  variables:
+    <<: *gcc
+
 # Jobs below this line
 
 archlinux-gcc:
@@ -617,6 +644,21 @@  alpine-3.12-gcc-debug-arm64-boot-cpupools:
     EXTRA_XEN_CONFIG: |
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
+# RISC-V 64 cross-build
+riscv64-cross-gcc:
+  extends: .gcc-riscv64-cross-build
+  variables:
+    CONTAINER: archlinux:riscv64
+    KBUILD_DEFCONFIG: tiny64_defconfig
+    HYPERVISOR_ONLY: y
+
+riscv64-cross-gcc-debug:
+  extends: .gcc-riscv64-cross-build-debug
+  variables:
+    CONTAINER: archlinux:riscv64
+    KBUILD_DEFCONFIG: tiny64_defconfig
+    HYPERVISOR_ONLY: y
+
 ## Test artifacts common
 
 .test-jobs-artifact-common:
@@ -692,3 +734,6 @@  kernel-5.10.74-export:
       - binaries/bzImage
   tags:
     - x86_64
+
+# # RISC-V 64 test artificats
+# # TODO: add RISC-V 64 test artitifacts