diff mbox series

trace-cmd: fix makefile cscope target

Message ID Y7YRrHaV+V6v+9WZ@mail.google.com (mailing list archive)
State Accepted
Commit 6a43c88ef5e771976099c229bac3a950ef09e48a
Headers show
Series trace-cmd: fix makefile cscope target | expand

Commit Message

Paulo Miguel Almeida Jan. 4, 2023, 11:54 p.m. UTC
existing cscope target using sh pipes was broken and cscope was throwing
the following error:

	$ make cscope
	[..]
	cscope: no source files found

fix cscope target by writing files to be indexed into a separate file
called cscope.files which cscope reads by default

Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Steven Rostedt Jan. 5, 2023, 12:58 a.m. UTC | #1
On Thu, 5 Jan 2023 12:54:20 +1300
Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> wrote:

> existing cscope target using sh pipes was broken and cscope was throwing
> the following error:
> 
> 	$ make cscope
> 	[..]
> 	cscope: no source files found
> 
> fix cscope target by writing files to be indexed into a separate file
> called cscope.files which cscope reads by default
> 

Thanks Paulo.

I don't use cscope, so I never tested it. In fact, I had to install it to
test this patch after I applied it ;-)

Anyway, I added it to the queue.

Thanks!

-- Steve
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 5a350b6..8c2496c 100644
--- a/Makefile
+++ b/Makefile
@@ -485,7 +485,8 @@  TAGS:	force
 
 cscope: force
 	$(RM) cscope*
-	$(call find_tag_files) | cscope -b -q
+	$(call find_tag_files) > cscope.files
+	cscope -b -q -f cscope.out
 
 install_plugins_tracecmd: force
 	$(Q)$(MAKE) -C $(src)/lib/trace-cmd/plugins install_plugins