| Message ID | 20230105003813.1770367-18-paulmck@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6305120eb744bf82dbe5513c619b6b262741d806 |
| Headers | show |
| Series | Unconditionally enable SRCU | expand |
On 2023/1/5 08:38, Paul E. McKenney wrote: > Now that the SRCU Kconfig option is unconditionally selected, there is > no longer any point in selecting it. Therefore, remove the "select SRCU" > Kconfig statements. > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Chris Mason <clm@fb.com> > Cc: Josef Bacik <josef@toxicpanda.com> > Cc: David Sterba <dsterba@suse.com> > Cc: <linux-btrfs@vger.kernel.org> In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we can completely remove any SRCU related configs and even includes. Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig > index 183e5c4aed348..37b6bab90c835 100644 > --- a/fs/btrfs/Kconfig > +++ b/fs/btrfs/Kconfig > @@ -17,7 +17,6 @@ config BTRFS_FS > select FS_IOMAP > select RAID6_PQ > select XOR_BLOCKS > - select SRCU > depends on PAGE_SIZE_LESS_THAN_256KB > > help
On Thu, Jan 05, 2023 at 05:06:09PM +0800, Qu Wenruo wrote: > > > On 2023/1/5 08:38, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig statements. > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Chris Mason <clm@fb.com> > > Cc: Josef Bacik <josef@toxicpanda.com> > > Cc: David Sterba <dsterba@suse.com> > > Cc: <linux-btrfs@vger.kernel.org> > > In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we can > completely remove any SRCU related configs and even includes. $ git grep srcu fs/btrfs/ fs/btrfs/disk-io.h: * fs_info->subvol_srcu I know that situation. ;-) > Reviewed-by: Qu Wenruo <wqu@suse.com> Thank you! I will update on my next rebase. Thanx, Paul > Thanks, > Qu > > > --- > > fs/btrfs/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig > > index 183e5c4aed348..37b6bab90c835 100644 > > --- a/fs/btrfs/Kconfig > > +++ b/fs/btrfs/Kconfig > > @@ -17,7 +17,6 @@ config BTRFS_FS > > select FS_IOMAP > > select RAID6_PQ > > select XOR_BLOCKS > > - select SRCU > > depends on PAGE_SIZE_LESS_THAN_256KB > > help
On Wed, Jan 04, 2023 at 04:38:04PM -0800, Paul E. McKenney wrote: > Now that the SRCU Kconfig option is unconditionally selected, there is > no longer any point in selecting it. Therefore, remove the "select SRCU" > Kconfig statements. > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Chris Mason <clm@fb.com> > Cc: Josef Bacik <josef@toxicpanda.com> > Cc: David Sterba <dsterba@suse.com> > Cc: <linux-btrfs@vger.kernel.org> Acked-by: David Sterba <dsterba@suse.com>
On Thu, Jan 05, 2023 at 04:45:18PM +0100, David Sterba wrote: > On Wed, Jan 04, 2023 at 04:38:04PM -0800, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig statements. > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Chris Mason <clm@fb.com> > > Cc: Josef Bacik <josef@toxicpanda.com> > > Cc: David Sterba <dsterba@suse.com> > > Cc: <linux-btrfs@vger.kernel.org> > > Acked-by: David Sterba <dsterba@suse.com> Thank you, David! I will apply this on my next rebase. Thanx, Paul
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig index 183e5c4aed348..37b6bab90c835 100644 --- a/fs/btrfs/Kconfig +++ b/fs/btrfs/Kconfig @@ -17,7 +17,6 @@ config BTRFS_FS select FS_IOMAP select RAID6_PQ select XOR_BLOCKS - select SRCU depends on PAGE_SIZE_LESS_THAN_256KB help
Now that the SRCU Kconfig option is unconditionally selected, there is no longer any point in selecting it. Therefore, remove the "select SRCU" Kconfig statements. Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Cc: Chris Mason <clm@fb.com> Cc: Josef Bacik <josef@toxicpanda.com> Cc: David Sterba <dsterba@suse.com> Cc: <linux-btrfs@vger.kernel.org> --- fs/btrfs/Kconfig | 1 - 1 file changed, 1 deletion(-)