diff mbox series

[1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

Message ID 20230106114403.275865-2-matti.lehtimaki@gmail.com (mailing list archive)
State Not Applicable
Headers show
Series General Purpose clocks and matisse-wifi backlight | expand

Commit Message

Matti Lehtimäki Jan. 6, 2023, 11:44 a.m. UTC
Document the general purpose clock functions that are found on MSM8226.

Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
 .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Jan. 6, 2023, 12:32 p.m. UTC | #1
On 06/01/2023 12:44, Matti Lehtimäki wrote:
> Document the general purpose clock functions that are found on MSM8226.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
>  .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> index 3b79f5be860b..6e3808065845 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> @@ -66,8 +66,8 @@ $defs:
>          enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5,
>                  blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1,
>                  blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2,
> -                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3,
> -                wlan ]
> +                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1,
> +                gp0_clk, gp1_clk, sdc3, wlan ]

Driver does not support them (and there is no driver change, unless you
cc-ed people selectively...).

Best regards,
Krzysztof
Matti Lehtimäki Jan. 6, 2023, 12:41 p.m. UTC | #2
On 6.1.2023 14.32, Krzysztof Kozlowski wrote:
> On 06/01/2023 12:44, Matti Lehtimäki wrote:
>> +                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0,
>> cam_mclk1, +                gp0_clk, gp1_clk, sdc3, wlan ]
> 
> Driver does not support them (and there is no driver change, unless
> you cc-ed people selectively...).

The driver changes are in patch number 2 of the series, I used
git send-mail with a cc script, which uses get_maintainer.pl to
get the needed addresses for each patch, to send the patches. It
probably didn't send every patch to everyone and would need some
improvement.

-Matti
Krzysztof Kozlowski Jan. 6, 2023, 1 p.m. UTC | #3
On 06/01/2023 13:41, Matti Lehtimäki wrote:
> On 6.1.2023 14.32, Krzysztof Kozlowski wrote:
>> On 06/01/2023 12:44, Matti Lehtimäki wrote:
>>> +                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0,
>>> cam_mclk1, +                gp0_clk, gp1_clk, sdc3, wlan ]
>>
>> Driver does not support them (and there is no driver change, unless
>> you cc-ed people selectively...).
> 
> The driver changes are in patch number 2 of the series, I used
> git send-mail with a cc script, which uses get_maintainer.pl to
> get the needed addresses for each patch, to send the patches. It
> probably didn't send every patch to everyone and would need some
> improvement.

Ah, ok, such method is recommended for big patchsets. In regular cases
please Cc everyone for all patches. I am using this one:

https://pastebin.com/HAjuht68

Best regards,
Krzysztof
Krzysztof Kozlowski Jan. 6, 2023, 1 p.m. UTC | #4
On 06/01/2023 12:44, Matti Lehtimäki wrote:
> Document the general purpose clock functions that are found on MSM8226.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
>  .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Linus Walleij Jan. 10, 2023, 7:57 a.m. UTC | #5
On Fri, Jan 6, 2023 at 12:44 PM Matti Lehtimäki
<matti.lehtimaki@gmail.com> wrote:

> Document the general purpose clock functions that are found on MSM8226.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index 3b79f5be860b..6e3808065845 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -66,8 +66,8 @@  $defs:
         enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5,
                 blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1,
                 blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2,
-                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3,
-                wlan ]
+                blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1,
+                gp0_clk, gp1_clk, sdc3, wlan ]
 
       bias-pull-down: true
       bias-pull-up: true