| Message ID | 20230104162215.31194-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: sun6i-csi: Fix format propagation in bridge | expand |
On Wednesday, 4 January 2023 16:22:13 GMT Laurent Pinchart wrote: > Hello, > > This small patch series fixes format propagation in the sun6i-csi-bridge > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > preparatory patch (1/2) that drops direct access to the bridge fields > from the capture side. > > I haven't tested the patches myself as I lack a hardware platform for > this, but Adam (on CC) has successfully tested them. Adam, if you want > to reply with a Tested-by tag, that would be appreciated. > > Laurent Pinchart (2): > media: sun6i-csi: capture: Use subdev operation to access bridge > format > media: sun6i-csi: subdev: Use subdev active state to store active > format > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > 3 files changed, 110 insertions(+), 133 deletions(-) > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2 Tested-by Adam Pigg <adam@piggz.co.uk> I have used these 2 patches, along with the other 5 here [1] to successfully capture frames on the Pinephone rear camera (ov5640) using libcamera and its cam utility. I will submit the other patches here shortly. [1] https://github.com/sailfish-on-dontbeevil/kernel-megi/commits/pinephone-libcamera
Hi Adam, On Thu, Jan 05, 2023 at 09:48:46PM +0000, Adam Pigg wrote: > On Wednesday, 4 January 2023 16:22:13 GMT Laurent Pinchart wrote: > > Hello, > > > > This small patch series fixes format propagation in the sun6i-csi-bridge > > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > > preparatory patch (1/2) that drops direct access to the bridge fields > > from the capture side. > > > > I haven't tested the patches myself as I lack a hardware platform for > > this, but Adam (on CC) has successfully tested them. Adam, if you want > > to reply with a Tested-by tag, that would be appreciated. > > > > Laurent Pinchart (2): > > media: sun6i-csi: capture: Use subdev operation to access bridge > > format > > media: sun6i-csi: subdev: Use subdev active state to store active > > format > > > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > > 3 files changed, 110 insertions(+), 133 deletions(-) > > > > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2 > > Tested-by Adam Pigg <adam@piggz.co.uk> Thank you. For the next time, note that there should be a column after Tested-by, as in Tested-by: Adam Pigg <adam@piggz.co.uk> Paul, if I could get your review on this, I'll include the patches in a pull request for v6.3. > I have used these 2 patches, along with the other 5 here [1] to successfully > capture frames on the Pinephone rear camera (ov5640) using libcamera and its > cam utility. > > I will submit the other patches here shortly. > > [1] https://github.com/sailfish-on-dontbeevil/kernel-megi/commits/pinephone-libcamera
Hi Paul, Ping for a review. I'd like to get this in v6.4. On Wed, Jan 04, 2023 at 06:22:13PM +0200, Laurent Pinchart wrote: > Hello, > > This small patch series fixes format propagation in the sun6i-csi-bridge > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > preparatory patch (1/2) that drops direct access to the bridge fields > from the capture side. > > I haven't tested the patches myself as I lack a hardware platform for > this, but Adam (on CC) has successfully tested them. Adam, if you want > to reply with a Tested-by tag, that would be appreciated. > > Laurent Pinchart (2): > media: sun6i-csi: capture: Use subdev operation to access bridge > format > media: sun6i-csi: subdev: Use subdev active state to store active > format > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > 3 files changed, 110 insertions(+), 133 deletions(-) > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2
Hello, This small patch series fixes format propagation in the sun6i-csi-bridge subdev from sink pad to source pad. In order to do so, it uses the V4L2 subdev active state provided by the V4L2 subdev core (patch 2/2), with a preparatory patch (1/2) that drops direct access to the bridge fields from the capture side. I haven't tested the patches myself as I lack a hardware platform for this, but Adam (on CC) has successfully tested them. Adam, if you want to reply with a Tested-by tag, that would be appreciated. Laurent Pinchart (2): media: sun6i-csi: capture: Use subdev operation to access bridge format media: sun6i-csi: subdev: Use subdev active state to store active format .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- 3 files changed, 110 insertions(+), 133 deletions(-) base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2