Message ID | 20230106092119.20449-1-quic_jinlmao@quicinc.com (mailing list archive) |
---|---|
Headers | show |
Series | Coresight: Add support for TPDM and TPDA | expand |
On 1/6/2023 1:21 AM, Mao Jinlong wrote: > This patch series depends on patch series: > "[v6,00/14] coresight: Add new API to allocate trace source ID values" > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221123195010.6859-1-mike.leach@linaro.org/ Do we know now when these patches will get revived and accepted to unblock us? ---Trilok Soni
Hi Suzuki, TPDM_TPDA commit tree: https://git.codelinaro.org/clo/linux-kernel/coresight/-/commits/tpdm-tpda-v16 Here is our TPDM and TPDA commit tree. You can use this link to review patches. Thanks Jinlong Mao On 1/6/2023 5:21 PM, Mao Jinlong wrote: > This series adds support for the trace performance monitoring and > diagnostics hardware (TPDM and TPDA). It is composed of two major > elements. > a) Changes for original coresight framework to support for TPDM and TPDA. > b) Add driver code for TPDM and TPDA. > > Introduction of changes for original coresight framework > Support TPDM as new coresight source. > Since only STM and ETM are supported as coresight source originally. > TPDM is a newly added coresight source. We need to change > the original way of saving coresight path to support more types source > for coresight driver. > The following patch is to add support more coresight sources. > coresight: core: Use IDR for non-cpu bound sources' paths. > > Introduction of TPDM and TPDA > TPDM - The trace performance monitoring and diagnostics monitor or TPDM in > short serves as data collection component for various dataset types > specified in the QPMDA(Qualcomm performance monitoring and diagnostics > architecture) spec. The primary use case of the TPDM is to collect data > from different data sources and send it to a TPDA for packetization, > timestamping and funneling. > Coresight: Add coresight TPDM source driver > dt-bindings: arm: Adds CoreSight TPDM hardware definitions > coresight-tpdm: Add DSB dataset support > coresight-tpdm: Add integration test support > > TPDA - The trace performance monitoring and diagnostics aggregator or > TPDA in short serves as an arbitration and packetization engine for the > performance monitoring and diagnostics network as specified in the QPMDA > (Qualcomm performance monitoring and diagnostics architecture) > specification. The primary use case of the TPDA is to provide > packetization, funneling and timestamping of Monitor data as specified > in the QPMDA specification. > The following patch is to add driver for TPDA. > Coresight: Add TPDA link driver > dt-bindings: arm: Adds CoreSight TPDA hardware definitions > > The last patch of this series is a device tree modification, which add > the TPDM and TPDA configuration to device tree for validating. > ARM: dts: msm: Add tpdm mm/prng for sm8250 > > Once this series patches are applied properly, the tpdm and tpda nodes > should be observed at the coresight path /sys/bus/coresight/devices > e.g. > /sys/bus/coresight/devices # ls -l | grep tpd > tpda0 -> ../../../devices/platform/soc@0/6004000.tpda/tpda0 > tpdm0 -> ../../../devices/platform/soc@0/6c08000.mm.tpdm/tpdm0 > > We can use the commands are similar to the below to validate TPDMs. > Enable coresight sink first. > > echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink > echo 1 > /sys/bus/coresight/devices/tpdm0/enable_source > echo 1 > /sys/bus/coresight/devices/tpdm0/integration_test > echo 2 > /sys/bus/coresight/devices/tpdm0/integration_test > The test data will be collected in the coresight sink which is enabled. > If rwp register of the sink is keeping updating when do > integration_test (by cat tmc_etf0/mgmt/rwp), it means there is data > generated from TPDM to sink. > > There must be a tpda between tpdm and the sink. When there are some > other trace event hw components in the same HW block with tpdm, tpdm > and these hw components will connect to the coresight funnel. When > there is only tpdm trace hw in the HW block, tpdm will connect to > tpda directly. > > +---------------+ +-------------+ > | tpdm@6c08000 | |tpdm@684C000 | > +-------|-------+ +------|------+ > | | > +-------|-------+ | > | funnel@6c0b000| | > +-------|-------+ | > | | > +-------|-------+ | > |funnel@6c2d000 | | > +-------|-------+ | > | | > | +---------------+ | > +----- tpda@6004000 -----------+ > +-------|-------+ > | > +-------|-------+ > |funnel@6005000 | > +---------------+ > > This patch series depends on patch series: > "[v6,00/14] coresight: Add new API to allocate trace source ID values" > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221123195010.6859-1-mike.leach@linaro.org/ > > TPDM_TPDA commit tree: > https://git.codelinaro.org/clo/linux-kernel/coresight/-/commits/tpdm-tpda-v16 > > Changes in V16: > 1. Update device tree changes to match up with device tree bindings. > 3. Update the copyright year to 2023. > > Changes in V15: > 1. coresight-tpda: Add more comments in trace id function. > 2. qcom,coresight-tpdm.yaml: Add more comments in description. > 3. Push "arm64: dts: qcom: sm8250: Add coresight components" out this series. > > Changes in V14: > rebase to "[v5,00/14] coresight: Add new API to allocate trace source ID values" and latest 6.x kernel > > Changes in V13: > 1. Fix the conflicts when apply patches to the latest base line. > > Changes in V12: > 1. Clear bits for atid before setting them and relese atid when tpda > remove. -- Suzuki K Poulose <suzuki.poulose@arm.com> > > Changes in V11: > 1. Change dev_info to dev_dbg in TPDM/TPDA drivers. -- Suzuki K Poulose <suzuki.poulose@arm.com> > 2. Merge sysfs API change of integration_test to integration_test driver > change. -- Suzuki K Poulose <suzuki.poulose@arm.com> > > Changes in V10: > 1. Fix the error of TPDM yaml file. -- Rob Herring <robh@kernel.org> > > Changes in V9: > 1. Rename yaml file for TPDM/TPDA and fix the error for the yaml files. > -- Rob Herring <robh@kernel.org> > > Changes in V8: > 1. Use spinlock to protect drvdata of TPDM/TPDA -- Suzuki K Poulose <suzuki.poulose@arm.com> > 2. Use CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS as source type for TPDM -- Suzuki K Poulose <suzuki.poulose@arm.com> > 3. Fix the warning for yaml file of TPDM/TPDA -- Rob Herring <robh@kernel.org> > > Changes in V7: > 1. Update the commit title and move the changes to right place which > is sorted by address for dtsi changes. -- Konrad Dybcio <konrad.dybcio@somainline.org> > > Changes in V6: > 1. Update maintainers in tpdm/tpda yaml file. -- Mike Leach <mike.leach@linaro.org> > 2. Set the .remove function pointer in the amba_driver structure > of tpdm/tpda driver. Add tpda_remove function for tpda driver. -- Mike Leach <mike.leach@linaro.org> > 3. Define datasets of tpdm as unsigned long. -- Mike Leach <mike.leach@linaro.org> > 4. Move all coresight nodes to sm8250.dtsi. > -- Mike Leach <mike.leach@linaro.org>;Konrad Dybcio <konrad.dybcio@somainline.org> > 5. Remove CORESIGHT_TPDM_INTEGRATION_TEST config. -- Mike Leach <mike.leach@linaro.org> > > Changes in V5: > 1. Keep the ETM source paths per-CPU and use IDR for other sources' > paths. (Suzuki K Poulose <suzuki.poulose@arm.com>) > > Changes in V4: > 1. Drop trace id for tpdm source as its trace atid is defined by the tpda. > Allocate tpda's atid dynamically. (Mike Leach) > > Changes in V3: > 1. Use bitmap to assign the trace id. (Mathieu Poirier) > > Changes in V2: > 1. Use IDR to store the path of sources. (Mathieu Poirier) > 2. Only add integration_test/enable/disable for TPDM. No other configs. > (Mathieu Poirier) > 3. Move coresight dtsi changes to sm8250.dtsi. (Suzuki K Poulose) > > Mao Jinlong (8): > coresight: core: Use IDR for non-cpu bound sources' paths. > Coresight: Add coresight TPDM source driver > dt-bindings: arm: Adds CoreSight TPDM hardware > coresight-tpdm: Add DSB dataset support > coresight-tpdm: Add integration test support > Coresight: Add TPDA link driver > dt-bindings: arm: Adds CoreSight TPDA hardware definitions > arm64: dts: qcom: sm8250: Add tpdm mm/prng > > .../testing/sysfs-bus-coresight-devices-tpdm | 13 + > .../bindings/arm/qcom,coresight-tpda.yaml | 129 +++++++++ > .../bindings/arm/qcom,coresight-tpdm.yaml | 93 +++++++ > MAINTAINERS | 1 + > arch/arm64/boot/dts/qcom/sm8250.dtsi | 164 +++++++++++ > drivers/hwtracing/coresight/Kconfig | 23 ++ > drivers/hwtracing/coresight/Makefile | 2 + > drivers/hwtracing/coresight/coresight-core.c | 42 ++- > drivers/hwtracing/coresight/coresight-tpda.c | 211 ++++++++++++++ > drivers/hwtracing/coresight/coresight-tpda.h | 35 +++ > drivers/hwtracing/coresight/coresight-tpdm.c | 259 ++++++++++++++++++ > drivers/hwtracing/coresight/coresight-tpdm.h | 62 +++++ > include/linux/coresight.h | 1 + > 13 files changed, 1023 insertions(+), 12 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml > create mode 100644 drivers/hwtracing/coresight/coresight-tpda.c > create mode 100644 drivers/hwtracing/coresight/coresight-tpda.h > create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.c > create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.h >
On 06/01/2023 20:50, Trilok Soni wrote: > On 1/6/2023 1:21 AM, Mao Jinlong wrote: >> This patch series depends on patch series: >> "[v6,00/14] coresight: Add new API to allocate trace source ID values" >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221123195010.6859-1-mike.leach@linaro.org/ > > Do we know now when these patches will get revived and accepted to > unblock us? This is all reviewed, and awaiting Peter's Ack for the perf generic change. Once we have that, it will be pushed to coresight tree. Suzuki
On 06/01/2023 09:21, Mao Jinlong wrote: > This series adds support for the trace performance monitoring and > diagnostics hardware (TPDM and TPDA). It is composed of two major > elements. > a) Changes for original coresight framework to support for TPDM and TPDA. > b) Add driver code for TPDM and TPDA. > > Introduction of changes for original coresight framework > Support TPDM as new coresight source. > Since only STM and ETM are supported as coresight source originally. > TPDM is a newly added coresight source. We need to change > the original way of saving coresight path to support more types source > for coresight driver. > The following patch is to add support more coresight sources. > coresight: core: Use IDR for non-cpu bound sources' paths. > > Introduction of TPDM and TPDA > TPDM - The trace performance monitoring and diagnostics monitor or TPDM in > short serves as data collection component for various dataset types > specified in the QPMDA(Qualcomm performance monitoring and diagnostics > architecture) spec. The primary use case of the TPDM is to collect data > from different data sources and send it to a TPDA for packetization, > timestamping and funneling. > Coresight: Add coresight TPDM source driver > dt-bindings: arm: Adds CoreSight TPDM hardware definitions > coresight-tpdm: Add DSB dataset support > coresight-tpdm: Add integration test support > > TPDA - The trace performance monitoring and diagnostics aggregator or > TPDA in short serves as an arbitration and packetization engine for the > performance monitoring and diagnostics network as specified in the QPMDA > (Qualcomm performance monitoring and diagnostics architecture) > specification. The primary use case of the TPDA is to provide > packetization, funneling and timestamping of Monitor data as specified > in the QPMDA specification. > The following patch is to add driver for TPDA. > Coresight: Add TPDA link driver > dt-bindings: arm: Adds CoreSight TPDA hardware definitions > > The last patch of this series is a device tree modification, which add > the TPDM and TPDA configuration to device tree for validating. > ARM: dts: msm: Add tpdm mm/prng for sm8250 > > Once this series patches are applied properly, the tpdm and tpda nodes > should be observed at the coresight path /sys/bus/coresight/devices > e.g. > /sys/bus/coresight/devices # ls -l | grep tpd > tpda0 -> ../../../devices/platform/soc@0/6004000.tpda/tpda0 > tpdm0 -> ../../../devices/platform/soc@0/6c08000.mm.tpdm/tpdm0 > > We can use the commands are similar to the below to validate TPDMs. > Enable coresight sink first. > > echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink > echo 1 > /sys/bus/coresight/devices/tpdm0/enable_source > echo 1 > /sys/bus/coresight/devices/tpdm0/integration_test > echo 2 > /sys/bus/coresight/devices/tpdm0/integration_test > The test data will be collected in the coresight sink which is enabled. > If rwp register of the sink is keeping updating when do > integration_test (by cat tmc_etf0/mgmt/rwp), it means there is data > generated from TPDM to sink. > > There must be a tpda between tpdm and the sink. When there are some > other trace event hw components in the same HW block with tpdm, tpdm > and these hw components will connect to the coresight funnel. When > there is only tpdm trace hw in the HW block, tpdm will connect to > tpda directly. > > +---------------+ +-------------+ > | tpdm@6c08000 | |tpdm@684C000 | > +-------|-------+ +------|------+ > | | > +-------|-------+ | > | funnel@6c0b000| | > +-------|-------+ | > | | > +-------|-------+ | > |funnel@6c2d000 | | > +-------|-------+ | > | | > | +---------------+ | > +----- tpda@6004000 -----------+ > +-------|-------+ > | > +-------|-------+ > |funnel@6005000 | > +---------------+ > > This patch series depends on patch series: > "[v6,00/14] coresight: Add new API to allocate trace source ID values" > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221123195010.6859-1-mike.leach@linaro.org/ > > TPDM_TPDA commit tree: > https://git.codelinaro.org/clo/linux-kernel/coresight/-/commits/tpdm-tpda-v16 > Please could you add a documentation for TPDA and TPDM under Documentation/tracing/coresight/ ? It need not be part of this series if you don't have to resend it. Kind regards Suzuki
On 1/10/2023 5:57 PM, Suzuki K Poulose wrote: > On 06/01/2023 09:21, Mao Jinlong wrote: >> This series adds support for the trace performance monitoring and >> diagnostics hardware (TPDM and TPDA). It is composed of two major >> elements. >> a) Changes for original coresight framework to support for TPDM and >> TPDA. >> b) Add driver code for TPDM and TPDA. >> >> Introduction of changes for original coresight framework >> Support TPDM as new coresight source. >> Since only STM and ETM are supported as coresight source originally. >> TPDM is a newly added coresight source. We need to change >> the original way of saving coresight path to support more types source >> for coresight driver. >> The following patch is to add support more coresight sources. >> coresight: core: Use IDR for non-cpu bound sources' paths. >> >> Introduction of TPDM and TPDA >> TPDM - The trace performance monitoring and diagnostics monitor or >> TPDM in >> short serves as data collection component for various dataset types >> specified in the QPMDA(Qualcomm performance monitoring and diagnostics >> architecture) spec. The primary use case of the TPDM is to collect data >> from different data sources and send it to a TPDA for packetization, >> timestamping and funneling. >> Coresight: Add coresight TPDM source driver >> dt-bindings: arm: Adds CoreSight TPDM hardware definitions >> coresight-tpdm: Add DSB dataset support >> coresight-tpdm: Add integration test support >> >> TPDA - The trace performance monitoring and diagnostics aggregator or >> TPDA in short serves as an arbitration and packetization engine for the >> performance monitoring and diagnostics network as specified in the QPMDA >> (Qualcomm performance monitoring and diagnostics architecture) >> specification. The primary use case of the TPDA is to provide >> packetization, funneling and timestamping of Monitor data as specified >> in the QPMDA specification. >> The following patch is to add driver for TPDA. >> Coresight: Add TPDA link driver >> dt-bindings: arm: Adds CoreSight TPDA hardware definitions >> >> The last patch of this series is a device tree modification, which add >> the TPDM and TPDA configuration to device tree for validating. >> ARM: dts: msm: Add tpdm mm/prng for sm8250 >> >> Once this series patches are applied properly, the tpdm and tpda nodes >> should be observed at the coresight path /sys/bus/coresight/devices >> e.g. >> /sys/bus/coresight/devices # ls -l | grep tpd >> tpda0 -> ../../../devices/platform/soc@0/6004000.tpda/tpda0 >> tpdm0 -> ../../../devices/platform/soc@0/6c08000.mm.tpdm/tpdm0 >> >> We can use the commands are similar to the below to validate TPDMs. >> Enable coresight sink first. >> >> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink >> echo 1 > /sys/bus/coresight/devices/tpdm0/enable_source >> echo 1 > /sys/bus/coresight/devices/tpdm0/integration_test >> echo 2 > /sys/bus/coresight/devices/tpdm0/integration_test >> The test data will be collected in the coresight sink which is enabled. >> If rwp register of the sink is keeping updating when do >> integration_test (by cat tmc_etf0/mgmt/rwp), it means there is data >> generated from TPDM to sink. >> >> There must be a tpda between tpdm and the sink. When there are some >> other trace event hw components in the same HW block with tpdm, tpdm >> and these hw components will connect to the coresight funnel. When >> there is only tpdm trace hw in the HW block, tpdm will connect to >> tpda directly. >> +---------------+ +-------------+ >> | tpdm@6c08000 | |tpdm@684C000 | >> +-------|-------+ +------|------+ >> | | >> +-------|-------+ | >> | funnel@6c0b000| | >> +-------|-------+ | >> | | >> +-------|-------+ | >> |funnel@6c2d000 | | >> +-------|-------+ | >> | | >> | +---------------+ | >> +----- tpda@6004000 -----------+ >> +-------|-------+ >> | >> +-------|-------+ >> |funnel@6005000 | >> +---------------+ >> >> This patch series depends on patch series: >> "[v6,00/14] coresight: Add new API to allocate trace source ID values" >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221123195010.6859-1-mike.leach@linaro.org/ >> >> >> TPDM_TPDA commit tree: >> https://git.codelinaro.org/clo/linux-kernel/coresight/-/commits/tpdm-tpda-v16 >> >> > > Please could you add a documentation for TPDA and TPDM under > Documentation/tracing/coresight/ ? > > It need not be part of this series if you don't have to resend it. > Hi Suzuki, Sure. I will add the documentation for TPDA and TPDM. Could you please review patches below which don't have your reviewed by tag ? If you have comments, I will update in next version along with the documentation for TPDA and TPDM. Coresight: Add TPDA link driver arm64: dts: qcom: sm8250: Add tpdm mm/prng Thanks Jinlong Mao > > Kind regards > Suzuki >