| Message ID | 20230105143228.244965-23-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Consolidate PIIX south bridges | expand |
On 05/01/2023 14:32, Bernhard Beschow wrote: > The Malta board, which is the only user of PIIX4, doesn't connect to the > exported interrupt lines. PIIX3 doesn't expose such intterupt lines typo here: s/intterupt/interrupt/ > either, so remove them for PIIX4 for simplicity and consistency. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > Message-Id: <20221022150508.26830-32-shentey@gmail.com> > --- > hw/isa/piix4.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c > index de4133f573..9edaa5de3e 100644 > --- a/hw/isa/piix4.c > +++ b/hw/isa/piix4.c > @@ -155,12 +155,6 @@ static void piix4_request_i8259_irq(void *opaque, int irq, int level) > qemu_set_irq(s->cpu_intr, level); > } > > -static void piix4_set_i8259_irq(void *opaque, int irq, int level) > -{ > - PIIX4State *s = opaque; > - qemu_set_irq(s->isa[irq], level); > -} > - > static void piix4_rcr_write(void *opaque, hwaddr addr, uint64_t val, > unsigned int len) > { > @@ -204,8 +198,6 @@ static void piix4_realize(PCIDevice *dev, Error **errp) > return; > } > > - qdev_init_gpio_in_named(DEVICE(dev), piix4_set_i8259_irq, > - "isa", ISA_NUM_IRQS); > qdev_init_gpio_out_named(DEVICE(dev), &s->cpu_intr, > "intr", 1); > ATB, Mark.
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index de4133f573..9edaa5de3e 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -155,12 +155,6 @@ static void piix4_request_i8259_irq(void *opaque, int irq, int level) qemu_set_irq(s->cpu_intr, level); } -static void piix4_set_i8259_irq(void *opaque, int irq, int level) -{ - PIIX4State *s = opaque; - qemu_set_irq(s->isa[irq], level); -} - static void piix4_rcr_write(void *opaque, hwaddr addr, uint64_t val, unsigned int len) { @@ -204,8 +198,6 @@ static void piix4_realize(PCIDevice *dev, Error **errp) return; } - qdev_init_gpio_in_named(DEVICE(dev), piix4_set_i8259_irq, - "isa", ISA_NUM_IRQS); qdev_init_gpio_out_named(DEVICE(dev), &s->cpu_intr, "intr", 1);