| Message ID | 20221230135645.56401-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: correct pins pattern | expand |
On Fri, Dec 30, 2022 at 02:56:38PM +0100, Krzysztof Kozlowski wrote: > Allow bias-bus-hold and input-enable properties (already used in > SC8280XP LPASS LPI nodes): > > sa8540p-ride.dtb: pinctrl@33c0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'function' is a required property > 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > 'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+' > 'gpio2' does not match '^gpio([0-1]|1[0-8])$' Wrong warning? > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > index 309d3dd9013b..9a3f1fb8c2f7 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > @@ -94,14 +94,12 @@ $defs: > 2: Lower Slew rate (slower edges) > 3: Reserved (No adjustments) > > + bias-bus-hold: true > bias-pull-down: true > - > bias-pull-up: true > - > bias-disable: true > - > + input-enable: true > output-high: true > - > output-low: true > > required: > -- > 2.34.1 > >
On 08/01/2023 21:08, Rob Herring wrote: > On Fri, Dec 30, 2022 at 02:56:38PM +0100, Krzysztof Kozlowski wrote: >> Allow bias-bus-hold and input-enable properties (already used in >> SC8280XP LPASS LPI nodes): >> >> sa8540p-ride.dtb: pinctrl@33c0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed: >> 'pins' is a required property >> 'function' is a required property >> 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' >> 'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+' >> 'gpio2' does not match '^gpio([0-1]|1[0-8])$' > > Wrong warning? No, it is still correct, just one warning for two issues: 1. patch 1 for wrong GPIO 2. patch 2 for bias-bus-hold I can drop last line here (gpio2 does not match). Best regards, Krzysztof
On Fri, 30 Dec 2022 14:56:38 +0100, Krzysztof Kozlowski wrote: > Allow bias-bus-hold and input-enable properties (already used in > SC8280XP LPASS LPI nodes): > > sa8540p-ride.dtb: pinctrl@33c0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'function' is a required property > 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > 'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+' > 'gpio2' does not match '^gpio([0-1]|1[0-8])$' > > [...] Corrected error log, as Rob pointed out. Applied, thanks! [2/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: add input-enable and bias-bus-hold https://git.kernel.org/krzk/linux-dt/c/a880fafbbac7e229752fb59bed56f55944dbe0e9 Best regards,
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml index 309d3dd9013b..9a3f1fb8c2f7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml @@ -94,14 +94,12 @@ $defs: 2: Lower Slew rate (slower edges) 3: Reserved (No adjustments) + bias-bus-hold: true bias-pull-down: true - bias-pull-up: true - bias-disable: true - + input-enable: true output-high: true - output-low: true required:
Allow bias-bus-hold and input-enable properties (already used in SC8280XP LPASS LPI nodes): sa8540p-ride.dtb: pinctrl@33c0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' 'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+' 'gpio2' does not match '^gpio([0-1]|1[0-8])$' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)