| Message ID | 20230109051402.317577-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: display/msm: rename mdss and mdp nodes | expand |
On Mon, 09 Jan 2023 07:13:57 +0200, Dmitry Baryshkov wrote: > Follow the 'generic names' rule and rename mdss nodes to > display-subsystem. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/display/msm/mdss-common.yaml | 8 ++++++++ > .../devicetree/bindings/display/msm/qcom,mdss.yaml | 5 ++++- > 2 files changed, 12 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.example.dtb: mdss@5e00000: $nodename:0: 'mdss@5e00000' does not match '^display-subsystem@[0-9a-f]+$' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.example.dtb: mdss@5e00000: $nodename:0: 'mdss@5e00000' does not match '^display-subsystem@[0-9a-f]+$' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230109051402.317577-2-dmitry.baryshkov@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Jan 09, 2023 at 07:13:57AM +0200, Dmitry Baryshkov wrote: > Follow the 'generic names' rule and rename mdss nodes to > display-subsystem. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/display/msm/mdss-common.yaml | 8 ++++++++ > .../devicetree/bindings/display/msm/qcom,mdss.yaml | 5 ++++- > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > index 59f17ac898aa..ccd7d6417523 100644 > --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > @@ -15,7 +15,15 @@ description: > Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates > sub-blocks like DPU display controller, DSI and DP interfaces etc. > > +# Do not select this by default, otherwise it is also selected for qcom,mdss > +# devices. for NON qcom,mdss devices? > +select: > + false select: false > + > properties: > + $nodename: > + pattern: "^display-subsystem@[0-9a-f]+$" > + > reg: > maxItems: 1 > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > index c218c9172608..47fde9b6779f 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > @@ -15,6 +15,9 @@ description: > encapsulates sub-blocks like MDP5, DSI, HDMI, eDP, etc. > > properties: > + $nodename: > + pattern: "^display-subsystem@[0-9a-f]+$" > + > compatible: > enum: > - qcom,mdss > @@ -153,7 +156,7 @@ examples: > - | > #include <dt-bindings/clock/qcom,gcc-msm8916.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > - mdss@1a00000 { > + display-subsystem@1a00000 { > compatible = "qcom,mdss"; > reg = <0x1a00000 0x1000>, > <0x1ac8000 0x3000>; > -- > 2.39.0 > >
On 09/01/2023 18:00, Rob Herring wrote: > On Mon, Jan 09, 2023 at 07:13:57AM +0200, Dmitry Baryshkov wrote: >> Follow the 'generic names' rule and rename mdss nodes to >> display-subsystem. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> .../devicetree/bindings/display/msm/mdss-common.yaml | 8 ++++++++ >> .../devicetree/bindings/display/msm/qcom,mdss.yaml | 5 ++++- >> 2 files changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml >> index 59f17ac898aa..ccd7d6417523 100644 >> --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml >> @@ -15,7 +15,15 @@ description: >> Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates >> sub-blocks like DPU display controller, DSI and DP interfaces etc. >> >> +# Do not select this by default, otherwise it is also selected for qcom,mdss >> +# devices. > > for NON qcom,mdss devices? Actually no. This schema is used by qcom,SoC-mdss devices and it should not be selected for legacy qcom,mdss devices. > >> +select: >> + false > > select: false > >> + >> properties: >> + $nodename: >> + pattern: "^display-subsystem@[0-9a-f]+$" >> + >> reg: >> maxItems: 1 >> >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml >> index c218c9172608..47fde9b6779f 100644 >> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml >> @@ -15,6 +15,9 @@ description: >> encapsulates sub-blocks like MDP5, DSI, HDMI, eDP, etc. >> >> properties: >> + $nodename: >> + pattern: "^display-subsystem@[0-9a-f]+$" >> + >> compatible: >> enum: >> - qcom,mdss >> @@ -153,7 +156,7 @@ examples: >> - | >> #include <dt-bindings/clock/qcom,gcc-msm8916.h> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> - mdss@1a00000 { >> + display-subsystem@1a00000 { >> compatible = "qcom,mdss"; >> reg = <0x1a00000 0x1000>, >> <0x1ac8000 0x3000>; >> -- >> 2.39.0 >> >>
diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index 59f17ac898aa..ccd7d6417523 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -15,7 +15,15 @@ description: Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates sub-blocks like DPU display controller, DSI and DP interfaces etc. +# Do not select this by default, otherwise it is also selected for qcom,mdss +# devices. +select: + false + properties: + $nodename: + pattern: "^display-subsystem@[0-9a-f]+$" + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml index c218c9172608..47fde9b6779f 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml @@ -15,6 +15,9 @@ description: encapsulates sub-blocks like MDP5, DSI, HDMI, eDP, etc. properties: + $nodename: + pattern: "^display-subsystem@[0-9a-f]+$" + compatible: enum: - qcom,mdss @@ -153,7 +156,7 @@ examples: - | #include <dt-bindings/clock/qcom,gcc-msm8916.h> #include <dt-bindings/interrupt-controller/arm-gic.h> - mdss@1a00000 { + display-subsystem@1a00000 { compatible = "qcom,mdss"; reg = <0x1a00000 0x1000>, <0x1ac8000 0x3000>;
Follow the 'generic names' rule and rename mdss nodes to display-subsystem. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../devicetree/bindings/display/msm/mdss-common.yaml | 8 ++++++++ .../devicetree/bindings/display/msm/qcom,mdss.yaml | 5 ++++- 2 files changed, 12 insertions(+), 1 deletion(-)