| Message ID | 20230106220020.1820147-3-anirudh.venkataramanan@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Remove three Sun net drivers | expand |
On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote: > The previous patch removed the Cassini driver (drivers/net/ethernet/sun). > With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are > unused. Remove them. > > Cc: Leon Romanovsky <leon@kernel.org> > Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> > --- > include/linux/pci_ids.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index b362d90..eca2340 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -433,7 +433,6 @@ > #define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e > #define PCI_DEVICE_ID_NS_CS5535_USB 0x002f > #define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030 > -#define PCI_DEVICE_ID_NS_SATURN 0x0035 > #define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500 > #define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501 > #define PCI_DEVICE_ID_NS_SCx200_IDE 0x0502 > @@ -1047,7 +1046,6 @@ > #define PCI_DEVICE_ID_SUN_SABRE 0xa000 > #define PCI_DEVICE_ID_SUN_HUMMINGBIRD 0xa001 > #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801 > -#define PCI_DEVICE_ID_SUN_CASSINI 0xabba I don't think there's value in removing these definitions. I would just leave them alone.
On 1/10/2023 7:26 AM, Bjorn Helgaas wrote: > On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote: >> The previous patch removed the Cassini driver (drivers/net/ethernet/sun). >> With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are >> unused. Remove them. >> >> Cc: Leon Romanovsky <leon@kernel.org> >> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> >> --- >> include/linux/pci_ids.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index b362d90..eca2340 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -433,7 +433,6 @@ >> #define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e >> #define PCI_DEVICE_ID_NS_CS5535_USB 0x002f >> #define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030 >> -#define PCI_DEVICE_ID_NS_SATURN 0x0035 >> #define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500 >> #define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501 >> #define PCI_DEVICE_ID_NS_SCx200_IDE 0x0502 >> @@ -1047,7 +1046,6 @@ >> #define PCI_DEVICE_ID_SUN_SABRE 0xa000 >> #define PCI_DEVICE_ID_SUN_HUMMINGBIRD 0xa001 >> #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801 >> -#define PCI_DEVICE_ID_SUN_CASSINI 0xabba > > I don't think there's value in removing these definitions. I would > just leave them alone. This whole series was NACK'd so this patch isn't getting applied. Ani
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index b362d90..eca2340 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -433,7 +433,6 @@ #define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e #define PCI_DEVICE_ID_NS_CS5535_USB 0x002f #define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030 -#define PCI_DEVICE_ID_NS_SATURN 0x0035 #define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500 #define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501 #define PCI_DEVICE_ID_NS_SCx200_IDE 0x0502 @@ -1047,7 +1046,6 @@ #define PCI_DEVICE_ID_SUN_SABRE 0xa000 #define PCI_DEVICE_ID_SUN_HUMMINGBIRD 0xa001 #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801 -#define PCI_DEVICE_ID_SUN_CASSINI 0xabba #define PCI_VENDOR_ID_NI 0x1093 #define PCI_DEVICE_ID_NI_PCI2322 0xd130
The previous patch removed the Cassini driver (drivers/net/ethernet/sun). With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are unused. Remove them. Cc: Leon Romanovsky <leon@kernel.org> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> --- include/linux/pci_ids.h | 2 -- 1 file changed, 2 deletions(-)