| Message ID | 20230103145515.1164020-16-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 353b18dca2c0abf7db85e59c6bdc459543317b43 |
| Headers | show |
| Series | clk: qcom: small cleanup | expand |
On Tue, Jan 3, 2023 at 7:56 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Change several entries of parent_data to use parent_hws instead, which > results in slightly more ovbious code. obvious -> obvious Also, you are changing one of two parent_data structs in this file. That's not "several". It's really not clear why you are touching one, but not the other. Can you be more specific about what is going on in this particular file?
On 03/01/2023 17:08, Jeffrey Hugo wrote: > On Tue, Jan 3, 2023 at 7:56 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> Change several entries of parent_data to use parent_hws instead, which >> results in slightly more ovbious code. > > obvious -> obvious > > Also, you are changing one of two parent_data structs in this file. > That's not "several". It's really not clear why you are touching one, > but not the other. Can you be more specific about what is going on in > this particular file? The other struct has .hw and .fw_data entries so it can not be switched to just clk_hw enumeration. I agree, that one is not 'several' (yeah, I was just using template for commit messages), I can change that for v2.
On Tue, Jan 03, 2023 at 06:00:28PM +0200, Dmitry Baryshkov wrote: > On 03/01/2023 17:08, Jeffrey Hugo wrote: > > On Tue, Jan 3, 2023 at 7:56 AM Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > Change several entries of parent_data to use parent_hws instead, which > > > results in slightly more ovbious code. > > > > obvious -> obvious > > > > Also, you are changing one of two parent_data structs in this file. > > That's not "several". It's really not clear why you are touching one, > > but not the other. Can you be more specific about what is going on in > > this particular file? > > The other struct has .hw and .fw_data entries so it can not be switched to > just clk_hw enumeration. > > I agree, that one is not 'several' (yeah, I was just using template for > commit messages), I can change that for v2. > While I dislike the copy-paste commit message, there's little point in spending more effort on it. I fixed the commit message of this one and picked the whole series. Thanks Dmitry, Bjorn > -- > With best wishes > Dmitry >
On 11/01/2023 00:13, Bjorn Andersson wrote: > On Tue, Jan 03, 2023 at 06:00:28PM +0200, Dmitry Baryshkov wrote: >> On 03/01/2023 17:08, Jeffrey Hugo wrote: >>> On Tue, Jan 3, 2023 at 7:56 AM Dmitry Baryshkov >>> <dmitry.baryshkov@linaro.org> wrote: >>>> >>>> Change several entries of parent_data to use parent_hws instead, which >>>> results in slightly more ovbious code. >>> >>> obvious -> obvious >>> >>> Also, you are changing one of two parent_data structs in this file. >>> That's not "several". It's really not clear why you are touching one, >>> but not the other. Can you be more specific about what is going on in >>> this particular file? >> >> The other struct has .hw and .fw_data entries so it can not be switched to >> just clk_hw enumeration. >> >> I agree, that one is not 'several' (yeah, I was just using template for >> commit messages), I can change that for v2. >> > > While I dislike the copy-paste commit message, there's little point in > spending more effort on it. I fixed the commit message of this one and > picked the whole series. Thanks!
diff --git a/drivers/clk/qcom/gpucc-msm8998.c b/drivers/clk/qcom/gpucc-msm8998.c index a925ac90018d..f929e0f2333f 100644 --- a/drivers/clk/qcom/gpucc-msm8998.c +++ b/drivers/clk/qcom/gpucc-msm8998.c @@ -106,9 +106,9 @@ static const struct parent_map gpu_xo_gpupll0_map[] = { { P_GPUPLL0_OUT_EVEN, 1 }, }; -static const struct clk_parent_data gpu_xo_gpupll0[] = { - { .hw = &gpucc_cxo_clk.clkr.hw }, - { .hw = &gpupll0_out_even.clkr.hw }, +static const struct clk_hw *gpu_xo_gpupll0[] = { + &gpucc_cxo_clk.clkr.hw, + &gpupll0_out_even.clkr.hw, }; static const struct freq_tbl ftbl_rbcpr_clk_src[] = { @@ -142,7 +142,7 @@ static struct clk_rcg2 gfx3d_clk_src = { .freq_tbl = ftbl_gfx3d_clk_src, .clkr.hw.init = &(struct clk_init_data){ .name = "gfx3d_clk_src", - .parent_data = gpu_xo_gpupll0, + .parent_hws = gpu_xo_gpupll0, .num_parents = ARRAY_SIZE(gpu_xo_gpupll0), .ops = &clk_rcg2_ops, .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE,
Change several entries of parent_data to use parent_hws instead, which results in slightly more ovbious code. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/gpucc-msm8998.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)