| Message ID | 20230111125855.19020-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: remove redundant config PCI dependency for some network driver configs | expand |
On Wed, Jan 11, 2023 at 01:58:55PM +0100, Lukas Bulwahn wrote: > [Some people who received this message don't often get email from lukas.bulwahn@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > While reviewing dependencies in some Kconfig files, I noticed the redundant > dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, > since its introduction, been dependent on the config PCI. So, it is > sufficient to just depend on PCI_MSI, and know that the dependency on PCI > is implicitly implied. > > Reduce the dependencies of some network driver configs. > No functional change and effective change of Kconfig dependendencies. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- > drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- > drivers/net/ethernet/netronome/Kconfig | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) For nfp portion. Acked-by: Simon Horman <simon.horman@corigine.com>
On Wed, Jan 11, 2023 at 4:59 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > While reviewing dependencies in some Kconfig files, I noticed the redundant > dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, > since its introduction, been dependent on the config PCI. So, it is > sufficient to just depend on PCI_MSI, and know that the dependency on PCI > is implicitly implied. > > Reduce the dependencies of some network driver configs. > No functional change and effective change of Kconfig dependendencies. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- > drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- > drivers/net/ethernet/netronome/Kconfig | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) For funeth part: Acked-by: Dimitris Michailidis <dmichail@fungible.com>
On Wed, 11 Jan 2023 13:58:55 +0100 Lukas Bulwahn wrote: > While reviewing dependencies in some Kconfig files, I noticed the redundant > dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, > since its introduction, been dependent on the config PCI. So, it is > sufficient to just depend on PCI_MSI, and know that the dependency on PCI > is implicitly implied. > > Reduce the dependencies of some network driver configs. > No functional change and effective change of Kconfig dependendencies. Applied, thanks!
diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig index cdc0ff89388a..6f6d07324d3b 100644 --- a/drivers/net/ethernet/freescale/enetc/Kconfig +++ b/drivers/net/ethernet/freescale/enetc/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 config FSL_ENETC tristate "ENETC PF driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select FSL_ENETC_IERB select FSL_ENETC_MDIO select PHYLINK @@ -16,7 +16,7 @@ config FSL_ENETC config FSL_ENETC_VF tristate "ENETC VF driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select FSL_ENETC_MDIO select PHYLINK select DIMLIB diff --git a/drivers/net/ethernet/fungible/funeth/Kconfig b/drivers/net/ethernet/fungible/funeth/Kconfig index c72ad9386400..e742e7663449 100644 --- a/drivers/net/ethernet/fungible/funeth/Kconfig +++ b/drivers/net/ethernet/fungible/funeth/Kconfig @@ -5,7 +5,7 @@ config FUN_ETH tristate "Fungible Ethernet device driver" - depends on PCI && PCI_MSI + depends on PCI_MSI depends on TLS && TLS_DEVICE || TLS_DEVICE=n select NET_DEVLINK select FUN_CORE diff --git a/drivers/net/ethernet/netronome/Kconfig b/drivers/net/ethernet/netronome/Kconfig index e785c00b5845..d03d6e96f730 100644 --- a/drivers/net/ethernet/netronome/Kconfig +++ b/drivers/net/ethernet/netronome/Kconfig @@ -18,7 +18,7 @@ if NET_VENDOR_NETRONOME config NFP tristate "Netronome(R) NFP4000/NFP6000 NIC driver" - depends on PCI && PCI_MSI + depends on PCI_MSI depends on VXLAN || VXLAN=n depends on TLS && TLS_DEVICE || TLS_DEVICE=n select NET_DEVLINK
While reviewing dependencies in some Kconfig files, I noticed the redundant dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend on PCI_MSI, and know that the dependency on PCI is implicitly implied. Reduce the dependencies of some network driver configs. No functional change and effective change of Kconfig dependendencies. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- drivers/net/ethernet/netronome/Kconfig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)