| Message ID | 20230111130206.29974-4-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Do not include <linux/fb.h> unnecessarily | expand |
On Wed, Jan 11, 2023 at 02:01:59PM +0100, Thomas Zimmermann wrote: > Including <linux/fb.h> in drm_crtc_helper.h is not required. Remove > the include statement and avoid rebuilding DRM whenever the fbdev > header changes. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > include/drm/drm_crtc_helper.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h > index 1840db247f69..072bc4f90349 100644 > --- a/include/drm/drm_crtc_helper.h > +++ b/include/drm/drm_crtc_helper.h > @@ -37,8 +37,6 @@ > #include <linux/types.h> > #include <linux/idr.h> ^ bunch of other unnecessary headers there as well. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > -#include <linux/fb.h> > - > #include <drm/drm_crtc.h> > #include <drm/drm_modeset_helper_vtables.h> > #include <drm/drm_modeset_helper.h> > -- > 2.39.0
diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h index 1840db247f69..072bc4f90349 100644 --- a/include/drm/drm_crtc_helper.h +++ b/include/drm/drm_crtc_helper.h @@ -37,8 +37,6 @@ #include <linux/types.h> #include <linux/idr.h> -#include <linux/fb.h> - #include <drm/drm_crtc.h> #include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_modeset_helper.h>
Including <linux/fb.h> in drm_crtc_helper.h is not required. Remove the include statement and avoid rebuilding DRM whenever the fbdev header changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- include/drm/drm_crtc_helper.h | 2 -- 1 file changed, 2 deletions(-)