[v2,00/10] drm: Do not include <linux/fb.h> unnecessarily

Message

Thomas Zimmermann Jan. 11, 2023, 1:01 p.m. UTC

Remove unnecessary include statements for <linux/fb.h>. I recently
changed this header and had to rebuild a good part of DRM. So avoid
this by removing the dependency.

Several files include <linux/fb.h> via drm_fb_helper.h. So in v2 I
added additional patches that remove some of those include statements
as well.

Some source files require the OF or backlight headers. Include those
instead.

v2:
	* add more patches to handle drm_fb_helper.h includes
	* fix komeda build (kernel test robot)

Thomas Zimmermann (10):
  drm: Include <linux/backlight.h> where needed
  drm: Include <linux/of.h> where needed
  drm: Don't include <linux/fb.h> in drm_crtc_helper.h
  drm/amdgpu: Do not include <linux/fb.h>
  drm/panel: Do not include <linux/fb.h>
  drm: Define enum mode_set_atomic in drm_modeset_helper_tables.h
  drm/amdgpu: Do not include <drm/drm_fb_helper.h>
  drm/nouveau: Do not include <drm/drm_fb_helper.h>
  drm/radeon: Remove trailing whitespaces
  drm/radeon: Do not include <drm/drm_fb_helper.h>

 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c                    | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c                     | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c                      | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c                      | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c                       | 1 -
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c                       | 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c           | 1 +
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c         | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c       | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c | 1 -
 drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c         | 1 -
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c             | 1 +
 drivers/gpu/drm/drm_modes.c                                 | 5 +++--
 drivers/gpu/drm/gma500/backlight.c                          | 2 ++
 drivers/gpu/drm/nouveau/dispnv04/crtc.c                     | 1 -
 drivers/gpu/drm/nouveau/nouveau_drm.c                       | 1 -
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c               | 1 -
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c       | 1 -
 drivers/gpu/drm/panel/panel-ronbo-rb070d30.c                | 2 +-
 drivers/gpu/drm/radeon/atombios_crtc.c                      | 1 -
 drivers/gpu/drm/radeon/radeon_acpi.c                        | 2 +-
 drivers/gpu/drm/radeon/radeon_connectors.c                  | 1 -
 drivers/gpu/drm/radeon/radeon_drv.c                         | 1 -
 drivers/gpu/drm/radeon/radeon_legacy_crtc.c                 | 3 +--
 include/drm/drm_crtc_helper.h                               | 2 --
 include/drm/drm_fb_helper.h                                 | 5 -----
 include/drm/drm_modeset_helper_vtables.h                    | 6 +++++-
 31 files changed, 16 insertions(+), 35 deletions(-)


base-commit: ac04152253dccfb02dcedfa0c57443122cf79314

Comments

Sam Ravnborg Jan. 13, 2023, 3:14 p.m. UTC | #1

Hi Thomas.
On Wed, Jan 11, 2023 at 02:01:56PM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <linux/fb.h>. I recently
> changed this header and had to rebuild a good part of DRM. So avoid
> this by removing the dependency.
> 
> Several files include <linux/fb.h> via drm_fb_helper.h. So in v2 I
> added additional patches that remove some of those include statements
> as well.
> 
> Some source files require the OF or backlight headers. Include those
> instead.
> 
> v2:
> 	* add more patches to handle drm_fb_helper.h includes
> 	* fix komeda build (kernel test robot)

Whole series are:
Acked-by: Sam Ravnborg <[e-mail]>

Except for the patches where I added an explicit r-b.

	Sam