| Message ID | 20230111172852.1875384-1-Raju.Rangoju@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | amd-xgbe: PFC and KR-Training fixes | expand |
On Wed, 11 Jan 2023 22:58:50 +0530 Raju Rangoju wrote: > 0001 - There is difference in the TX Flow Control registers (TFCR) > between the revisions of the hardware. Update the driver to use the > TFCR based on the reported version of the hardware. > > 0002 - AN restart triggered during KR training not only aborts the KR > training process but also move the HW to unstable state. Add the > necessary changes to fix kr-taining. Please err on the side of CCing people. Here the patches under Fixes have Tom's sign off which makes our automation complain that he's not CCed. No tag from him either.
On 1/12/2023 11:12 AM, Jakub Kicinski wrote: > On Wed, 11 Jan 2023 22:58:50 +0530 Raju Rangoju wrote: >> 0001 - There is difference in the TX Flow Control registers (TFCR) >> between the revisions of the hardware. Update the driver to use the >> TFCR based on the reported version of the hardware. >> >> 0002 - AN restart triggered during KR training not only aborts the KR >> training process but also move the HW to unstable state. Add the >> necessary changes to fix kr-taining. > > Please err on the side of CCing people. Here the patches under Fixes > have Tom's sign off which makes our automation complain that he's not > CCed. No tag from him either. > I have put an Ack tag to the patches in the series, being the additional maintainer for this driver. As Tom is busy working on other areas, I shall be a single maintainer for this driver going forward. I can submit a patch for the change to the MAINTAINERS file. But would you mind pulling this series for now? Or would you like to see the MAINTAINERS file getting updated first? Thanks, Shyam
On Thu, 12 Jan 2023 11:19:34 +0530 Shyam Sundar S K wrote: > I have put an Ack tag to the patches in the series, being the additional > maintainer for this driver. As Tom is busy working on other areas, I > shall be a single maintainer for this driver going forward. > > I can submit a patch for the change to the MAINTAINERS file. For Fixes of code that someone authored it'd be better if the person is CCed, as long as their email address still works. For net-next material, if you're posting as a co-maintainer not CCing other maintainers is no big deal. > But would you mind pulling this series for now? Or would you like to see > the MAINTAINERS file getting updated first? Yes, no need to repost this one. Just something to keep in mind for the future.
On 1/13/2023 4:06 AM, Jakub Kicinski wrote: > On Thu, 12 Jan 2023 11:19:34 +0530 Shyam Sundar S K wrote: >> I have put an Ack tag to the patches in the series, being the additional >> maintainer for this driver. As Tom is busy working on other areas, I >> shall be a single maintainer for this driver going forward. >> >> I can submit a patch for the change to the MAINTAINERS file. > > For Fixes of code that someone authored it'd be better if the person > is CCed, as long as their email address still works. For net-next > material, if you're posting as a co-maintainer not CCing other > maintainers is no big deal. Noted. > >> But would you mind pulling this series for now? Or would you like to see >> the MAINTAINERS file getting updated first? > > Yes, no need to repost this one. Just something to keep in mind for > the future. > Thanks! Will take care of thie is future. Thanks, Shyam
On Wed, 11 Jan 2023 22:58:50 +0530 Raju Rangoju wrote: > This patch series fixes the issues in kr-training and pfc > > Patches: > > 0001 - There is difference in the TX Flow Control registers (TFCR) > between the revisions of the hardware. Update the driver to use the > TFCR based on the reported version of the hardware. > > 0002 - AN restart triggered during KR training not only aborts the KR > training process but also move the HW to unstable state. Add the > necessary changes to fix kr-taining. Applied, thanks!