| Message ID | 7c1809dc74eb2f58a20595f4d02e76934f8e9219.camel@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: hid: fix the retval in gyro_3d_capture_sample | expand |
On Wed, 11 Jan 2023 14:24:25 +0200 Dmitry Perchanov <dmitry.perchanov@intel.com> wrote: > Return value should be zero for success. > This was forgotten for timestamp feature. > Verified on RealSense cameras. > > Fixes: 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel") > > Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com> Applied with patch description white space tidied up (wrap at 75 chars, not blank lines in tags block). Applied to the fixes-togreg branch of iio.git and marked for stable inclusion. Thanks, Jonathan > --- > drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c > index 8f0ad022c..698c50da1 100644 > --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c > +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c > @@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev, > gyro_state->timestamp = > hid_sensor_convert_timestamp(&gyro_state->common_attributes, > *(s64 *)raw_data); > + ret = 0; > break; > default: > break;
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c index 8f0ad022c..698c50da1 100644 --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c @@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev, gyro_state->timestamp = hid_sensor_convert_timestamp(&gyro_state->common_attributes, *(s64 *)raw_data); + ret = 0; break; default: break;
Return value should be zero for success. This was forgotten for timestamp feature. Verified on RealSense cameras. Fixes: 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel") Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com> --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 + 1 file changed, 1 insertion(+)