| Message ID | 20230113001132.3375334-17-paulmck@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e5a5a4c1a9b2e06d0da013cb553d8ca104600696 |
| Headers | show |
| Series | [v2,01/20] arch/x86: Remove "select SRCU" | expand |
On Thu, Jan 12, 2023, Paul E. McKenney wrote: > Now that the SRCU Kconfig option is unconditionally selected, there is > no longer any point in selecting it. Therefore, remove the "select SRCU" > Kconfig statements from the various KVM Kconfig files. > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Huacai Chen <chenhuacai@kernel.org> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Sean Christopherson <seanjc@google.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: <kvm@vger.kernel.org> > Acked-by: Marc Zyngier <maz@kernel.org> (arm64) > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) > Acked-by: Anup Patel <anup@brainfault.org> (riscv) > Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390) > Reviewed-by: John Ogness <john.ogness@linutronix.de> > --- Reviewed-by: Sean Christopherson <seanjc@google.com> Ugh, my apologies Paul. I didn't realize 0cd7e350abc4 ("rcu: Make SRCU mandatory") is already in Linus' tree, i.e. bundling this in a single patch was unnecessary work for you. Anyways, since there isn't an external dependency, this can go through the KVM tree. Unless you prefer to take it directly, I'll make sure Paolo sends it along at some point before v6.2 final.
On Wed, Jan 18, 2023 at 01:27:36AM +0000, Sean Christopherson wrote: > On Thu, Jan 12, 2023, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig statements from the various KVM Kconfig files. > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Huacai Chen <chenhuacai@kernel.org> > > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > Cc: Michael Ellerman <mpe@ellerman.id.au> > > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > > Cc: Sean Christopherson <seanjc@google.com> > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Borislav Petkov <bp@alien8.de> > > Cc: Dave Hansen <dave.hansen@linux.intel.com> > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > Cc: <kvm@vger.kernel.org> > > Acked-by: Marc Zyngier <maz@kernel.org> (arm64) > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) > > Acked-by: Anup Patel <anup@brainfault.org> (riscv) > > Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390) > > Reviewed-by: John Ogness <john.ogness@linutronix.de> > > --- > > Reviewed-by: Sean Christopherson <seanjc@google.com> > > > Ugh, my apologies Paul. I didn't realize 0cd7e350abc4 ("rcu: Make SRCU mandatory") > is already in Linus' tree, i.e. bundling this in a single patch was unnecessary work > for you. > > Anyways, since there isn't an external dependency, this can go through the KVM > tree. Unless you prefer to take it directly, I'll make sure Paolo sends it along > at some point before v6.2 final. I am very happy to have you guys take it. Just let me know when you have it in place, and I will drop my copy on my next rebase after that. Thanx, Paul
diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig index 05da3c8f7e88f..312f0e9869111 100644 --- a/arch/arm64/kvm/Kconfig +++ b/arch/arm64/kvm/Kconfig @@ -28,7 +28,6 @@ menuconfig KVM select KVM_MMIO select KVM_GENERIC_DIRTYLOG_READ_PROTECT select KVM_XFER_TO_GUEST_WORK - select SRCU select KVM_VFIO select HAVE_KVM_EVENTFD select HAVE_KVM_IRQFD diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig index 91d197bee9c0a..591f46a5d7be1 100644 --- a/arch/mips/kvm/Kconfig +++ b/arch/mips/kvm/Kconfig @@ -26,7 +26,6 @@ config KVM select HAVE_KVM_VCPU_ASYNC_IOCTL select KVM_MMIO select MMU_NOTIFIER - select SRCU select INTERVAL_TREE help Support for hosting Guest kernels. diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig index a9f57dad6d916..902611954200d 100644 --- a/arch/powerpc/kvm/Kconfig +++ b/arch/powerpc/kvm/Kconfig @@ -22,7 +22,6 @@ config KVM select PREEMPT_NOTIFIERS select HAVE_KVM_EVENTFD select HAVE_KVM_VCPU_ASYNC_IOCTL - select SRCU select KVM_VFIO select IRQ_BYPASS_MANAGER select HAVE_KVM_IRQ_BYPASS diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig index f36a737d5f96d..6bc9b290c1283 100644 --- a/arch/riscv/kvm/Kconfig +++ b/arch/riscv/kvm/Kconfig @@ -27,7 +27,6 @@ config KVM select KVM_XFER_TO_GUEST_WORK select HAVE_KVM_VCPU_ASYNC_IOCTL select HAVE_KVM_EVENTFD - select SRCU help Support hosting virtualized guest machines. diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig index 33f4ff909476c..45fdf2a9b2e32 100644 --- a/arch/s390/kvm/Kconfig +++ b/arch/s390/kvm/Kconfig @@ -31,7 +31,6 @@ config KVM select HAVE_KVM_IRQ_ROUTING select HAVE_KVM_INVALID_WAKEUPS select HAVE_KVM_NO_POLL - select SRCU select KVM_VFIO select INTERVAL_TREE select MMU_NOTIFIER diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig index fbeaa9ddef598..9306d99585188 100644 --- a/arch/x86/kvm/Kconfig +++ b/arch/x86/kvm/Kconfig @@ -46,7 +46,6 @@ config KVM select KVM_XFER_TO_GUEST_WORK select KVM_GENERIC_DIRTYLOG_READ_PROTECT select KVM_VFIO - select SRCU select INTERVAL_TREE select HAVE_KVM_PM_NOTIFIER if PM help