diff mbox series

[2/3] xfs/{080,329,434,436}: add missing check for fallocate support

Message ID 167400102773.1914975.13189675469601933878.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: fix tests when XFS always_cow mode enabled | expand

Commit Message

Darrick J. Wong Jan. 18, 2023, 12:43 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Don't run this test if the filesystem doesn't support fallocate.  This
is only ever the case if always_cow is enabled.

The same logic applies to xfs/329, though it's more subtle because the
test itself does not explicitly invoke fallocate; rather, it is xfs_fsr
that requires fallocate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/080 |    1 +
 tests/xfs/329 |    1 +
 tests/xfs/434 |    1 +
 tests/xfs/436 |    1 +
 4 files changed, 4 insertions(+)

Comments

Christoph Hellwig Jan. 18, 2023, 5:43 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/080 b/tests/xfs/080
index 20b20a08eb..abcfa004b5 100755
--- a/tests/xfs/080
+++ b/tests/xfs/080
@@ -21,6 +21,7 @@  _cleanup()
 
 _supported_fs xfs
 _require_test
+_require_xfs_io_command falloc	# iogen requires falloc
 
 quiet=-q
 clean=-c
diff --git a/tests/xfs/329 b/tests/xfs/329
index 4cad686c17..15dc3c242f 100755
--- a/tests/xfs/329
+++ b/tests/xfs/329
@@ -22,6 +22,7 @@  _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
+_require_xfs_io_command falloc	# fsr requires support for preallocation
 
 rm -f "$seqres.full"
 
diff --git a/tests/xfs/434 b/tests/xfs/434
index 576f1b0e1e..de52531053 100755
--- a/tests/xfs/434
+++ b/tests/xfs/434
@@ -35,6 +35,7 @@  _require_quota
 _require_scratch_reflink
 _require_cp_reflink
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt
 
diff --git a/tests/xfs/436 b/tests/xfs/436
index 9e6ec9372d..b95da8abf4 100755
--- a/tests/xfs/436
+++ b/tests/xfs/436
@@ -30,6 +30,7 @@  _supported_fs xfs
 _require_loadable_fs_module "xfs"
 _require_scratch_reflink
 _require_cp_reflink
+_require_xfs_io_command falloc # fsr requires support for preallocation
 _require_command "$XFS_FSR_PROG" "xfs_fsr"
 _require_xfs_io_error_injection "bmap_finish_one"
 _require_xfs_scratch_rmapbt