| Message ID | 916d01663e76a3a0acad93f6c234834deaa2dd72.1674131459.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Basic early_printk and smoke test implementation | expand |
On 19.01.2023 15:07, Oleksii Kurochko wrote: > In the patch "include/types: move stddef.h-kind types to common > header" [1] size_t was moved from <asm/types.h> to <xen/types.h> > so early_printk should be updated correspondingly. Hmm, this reads a little like that patch would introduce a build issue (on Arm), but according to my testing it doesn't. If it did, the change here would need to be part of that (not yet committed) change. On the assumption that it really doesn't, ... > [1] https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> Acked-by: Jan Beulich <jbeulich@suse.com> Jan
On 19.01.2023 15:29, Jan Beulich wrote: > On 19.01.2023 15:07, Oleksii Kurochko wrote: >> In the patch "include/types: move stddef.h-kind types to common >> header" [1] size_t was moved from <asm/types.h> to <xen/types.h> >> so early_printk should be updated correspondingly. > > Hmm, this reads a little like that patch would introduce a build > issue (on Arm), but according to my testing it doesn't. If it did, > the change here would need to be part of that (not yet committed) > change. On the assumption that it really doesn't, ... > >> [1] https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ >> >> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> Actually I notice we have more explicit uses of asm/types.h, and hence the title of this change isn't really correct (with this title I would expect all uses to go away underneath xen/include/xen). I'll try to remember to adjust the title when committing. Jan
On Thu, 2023-01-19 at 16:43 +0100, Jan Beulich wrote: > On 19.01.2023 15:29, Jan Beulich wrote: > > On 19.01.2023 15:07, Oleksii Kurochko wrote: > > > In the patch "include/types: move stddef.h-kind types to common > > > header" [1] size_t was moved from <asm/types.h> to <xen/types.h> > > > so early_printk should be updated correspondingly. > > > > Hmm, this reads a little like that patch would introduce a build > > issue (on Arm), but according to my testing it doesn't. If it did, > > the change here would need to be part of that (not yet committed) > > change. On the assumption that it really doesn't, ... > > > > > [1] > > > https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ > > > > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > > > Acked-by: Jan Beulich <jbeulich@suse.com> > > Actually I notice we have more explicit uses of asm/types.h, and > hence the title of this change isn't really correct (with this It's really uncorrect. I was in a hurry, my fault. I meant that change <asm/types.h> to <xen/types.h> only for <xen/early_printk.h>. > title I would expect all uses to go away underneath xen/include/xen). > I'll try to remember to adjust the title when committing. > Thanks for that. > Jan > ~ Oleksii
diff --git a/xen/include/xen/early_printk.h b/xen/include/xen/early_printk.h index abb34687da..5d72293793 100644 --- a/xen/include/xen/early_printk.h +++ b/xen/include/xen/early_printk.h @@ -4,7 +4,7 @@ #ifndef __XEN_EARLY_PRINTK_H__ #define __XEN_EARLY_PRINTK_H__ -#include <asm/types.h> +#include <xen/types.h> #ifdef CONFIG_EARLY_PRINTK void early_puts(const char *s, size_t nr);
In the patch "include/types: move stddef.h-kind types to common header" [1] size_t was moved from <asm/types.h> to <xen/types.h> so early_printk should be updated correspondingly. [1] https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- xen/include/xen/early_printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)