| Message ID | 20230119155417.2600-2-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7e92586c28a50dd5875655c0d169184a5acb0eee |
| Delegated to: | Palmer Dabbelt |
| Headers | show |
| Series | riscv: improve link and support ARCH_WANT_LD_ORPHAN_WARN | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 13 and now 13 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 57 and now 57 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 2 this patch: 2 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Thu, Jan 19, 2023 at 11:54:13PM +0800, Jisheng Zhang wrote: > riscv discards .exit.* sections at run-time but doesn't define > RUNTIME_DISCARD_EXIT. However, the .exit.* sections are still allocated > and kept even if the generic DISCARDS would discard the sections due > to missing RUNTIME_DISCARD_EXIT, because the DISCARD sits at the end of > the linker script. Add the missing RUNTIME_DISCARD_EXIT define so that > it still works if we move DISCARD up or even at the beginning of the > linker script. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Suggested-by: Masahiro Yamada <masahiroy@kernel.org> Thought I left one of these against v1, either way: Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S index 4e6c88aa4d87..07c19f2a288c 100644 --- a/arch/riscv/kernel/vmlinux.lds.S +++ b/arch/riscv/kernel/vmlinux.lds.S @@ -5,6 +5,7 @@ */ #define RO_EXCEPTION_TABLE_ALIGN 4 +#define RUNTIME_DISCARD_EXIT #ifdef CONFIG_XIP_KERNEL #include "vmlinux-xip.lds.S"
riscv discards .exit.* sections at run-time but doesn't define RUNTIME_DISCARD_EXIT. However, the .exit.* sections are still allocated and kept even if the generic DISCARDS would discard the sections due to missing RUNTIME_DISCARD_EXIT, because the DISCARD sits at the end of the linker script. Add the missing RUNTIME_DISCARD_EXIT define so that it still works if we move DISCARD up or even at the beginning of the linker script. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> Suggested-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/riscv/kernel/vmlinux.lds.S | 1 + 1 file changed, 1 insertion(+)