mbox series

[v7,0/3] thermal: intel: Use generic trip points in 2 drivers

Message ID 5916342.lOV4Wx5bFT@kreacher (mailing list archive)
Headers show
Series thermal: intel: Use generic trip points in 2 drivers | expand

Message

Rafael J. Wysocki Jan. 23, 2023, 6:36 p.m. UTC
Hi All,

This is a new version of the series from Daniel posted as:

https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/

The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
and the other two have been rebased on top of it.

I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
not essential, but I think that this new set needs to be tested again.

Srinivas, can you test it please?

Thanks!

Comments

Rafael J. Wysocki Jan. 23, 2023, 6:45 p.m. UTC | #1
On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> Hi All,
> 
> This is a new version of the series from Daniel posted as:
> 
> https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> 
> The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> and the other two have been rebased on top of it.
> 
> I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
> not essential, but I think that this new set needs to be tested again.
> 
> Srinivas, can you test it please?

Something's wrong, sorry.

I get some invalid trip temperatures with this set.
Rafael J. Wysocki Jan. 23, 2023, 6:52 p.m. UTC | #2
On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > Hi All,
> > 
> > This is a new version of the series from Daniel posted as:
> > 
> > https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> > 
> > The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > and the other two have been rebased on top of it.
> > 
> > I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
> > not essential, but I think that this new set needs to be tested again.
> > 
> > Srinivas, can you test it please?
> 
> Something's wrong, sorry.
> 
> I get some invalid trip temperatures with this set.

Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing up in
sysfs, but it did show up before too.

Please test!
srinivas pandruvada Jan. 23, 2023, 7:26 p.m. UTC | #3
On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > > Hi All,
> > > 
> > > This is a new version of the series from Daniel posted as:
> > > 
> > > https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> > > 
> > > The first patch has been reworked (see
> > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > > and the other two have been rebased on top of it.
> > > 
> > > I have retained the R-by tags from Rui, because the changes in
> > > patches [2-3/3] are
> > > not essential, but I think that this new set needs to be tested
> > > again.
> > > 
> > > Srinivas, can you test it please?
> > 
> > Something's wrong, sorry.
> > 
> > I get some invalid trip temperatures with this set.
> 
> Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing
> up in
> sysfs, but it did show up before too.
> 
> Please test!
> 

> 

> 
> It will be easy if you have some test branch to avoid dependecies on
> other patches.

Thanks,
Srinivas

> 
>
Rafael J. Wysocki Jan. 23, 2023, 7:54 p.m. UTC | #4
On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > > > Hi All,
> > > >
> > > > This is a new version of the series from Daniel posted as:
> > > >
> > > > https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> > > >
> > > > The first patch has been reworked (see
> > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > > > and the other two have been rebased on top of it.
> > > >
> > > > I have retained the R-by tags from Rui, because the changes in
> > > > patches [2-3/3] are
> > > > not essential, but I think that this new set needs to be tested
> > > > again.
> > > >
> > > > Srinivas, can you test it please?
> > >
> > > Something's wrong, sorry.
> > >
> > > I get some invalid trip temperatures with this set.
> >
> > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing
> > up in
> > sysfs, but it did show up before too.
> >
> > Please test!
> >
>
> >
>
> >
> It will be easy if you have some test branch to avoid dependecies on
> other patches.

Please see the thermal-intel-test branch in linux-pm.git.  It's this
series on top of the core thermal stuff + ARM drivers.
srinivas pandruvada Jan. 23, 2023, 9:35 p.m. UTC | #5
On Mon, 2023-01-23 at 20:54 +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > 
> > On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki
> > > wrote:
> > > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki
> > > > wrote:
> > > > > Hi All,
> > > > > 
> > > > > This is a new version of the series from Daniel posted as:
> > > > > 
> > > > > https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> > > > > 
> > > > > The first patch has been reworked (see
> > > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/
> > > > > )
> > > > > and the other two have been rebased on top of it.
> > > > > 
> > > > > I have retained the R-by tags from Rui, because the changes
> > > > > in
> > > > > patches [2-3/3] are
> > > > > not essential, but I think that this new set needs to be
> > > > > tested
> > > > > again.
> > > > > 
> > > > > Srinivas, can you test it please?
> > > > 
> > > > Something's wrong, sorry.
> > > > 
> > > > I get some invalid trip temperatures with this set.
> > > 
> > > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID
> > > showing
> > > up in
> > > sysfs, but it did show up before too.
> > > 
> > > Please test!
> > > 
> > 
> > > 
> > 
> > > 
> > It will be easy if you have some test branch to avoid dependecies
> > on
> > other patches.
> 
> Please see the thermal-intel-test branch in linux-pm.git.  It's this
> series on top of the core thermal stuff + ARM drivers.
Tested on one system. Works fine.

Thanks,
Srinivas
Rafael J. Wysocki Jan. 24, 2023, 2:52 p.m. UTC | #6
On Mon, Jan 23, 2023 at 10:35 PM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Mon, 2023-01-23 at 20:54 +0100, Rafael J. Wysocki wrote:
> > On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
> > <srinivas.pandruvada@linux.intel.com> wrote:
> > >
> > > On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > > > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki
> > > > wrote:
> > > > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki
> > > > > wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > This is a new version of the series from Daniel posted as:
> > > > > >
> > > > > > https://lore.kernel.org/linux-pm/20230120231530.2368330-1-daniel.lezcano@linaro.org/
> > > > > >
> > > > > > The first patch has been reworked (see
> > > > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/
> > > > > > )
> > > > > > and the other two have been rebased on top of it.
> > > > > >
> > > > > > I have retained the R-by tags from Rui, because the changes
> > > > > > in
> > > > > > patches [2-3/3] are
> > > > > > not essential, but I think that this new set needs to be
> > > > > > tested
> > > > > > again.
> > > > > >
> > > > > > Srinivas, can you test it please?
> > > > >
> > > > > Something's wrong, sorry.
> > > > >
> > > > > I get some invalid trip temperatures with this set.
> > > >
> > > > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID
> > > > showing
> > > > up in
> > > > sysfs, but it did show up before too.
> > > >
> > > > Please test!
> > > >
> > >
> > > >
> > >
> > > >
> > > It will be easy if you have some test branch to avoid dependecies
> > > on
> > > other patches.
> >
> > Please see the thermal-intel-test branch in linux-pm.git.  It's this
> > series on top of the core thermal stuff + ARM drivers.
> Tested on one system. Works fine.

Thanks!

I'll add a T-by from you to the series (which will be moved to the
thermal-intel branch).