| Message ID | 20230124013014.23578-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: atomisp: fix build error, use vb2 interfaces | expand |
Hi Randy, On 1/24/23 02:30, Randy Dunlap wrote: > The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC > instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct > interfaces are built. > > ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe': > drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops' > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: linux-media@vger.kernel.org Thank you for the patch, the same patch was already posted by Arnd a while ago: https://lore.kernel.org/linux-media/20230104082212.3770415-1-arnd@kernel.org/ but this has unfortunately not found its way to Linus' tree yet. Regards, Hans > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC >
diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -14,7 +14,7 @@ config VIDEO_ATOMISP depends on VIDEO_DEV && INTEL_ATOMISP depends on PMIC_OPREGION select IOSF_MBI - select VIDEOBUF_VMALLOC + select VIDEOBUF2_VMALLOC select VIDEO_V4L2_SUBDEV_API help Say Y here if your platform supports Intel Atom SoC
The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct interfaces are built. ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe': drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops' Reported-by: kernel test robot <lkp@intel.com> Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: linux-media@vger.kernel.org --- drivers/staging/media/atomisp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)