mbox series

[v5,0/5] linux-user: implement execveat

Message ID 20221104173632.1052-1-philmd@linaro.org (mailing list archive)
Headers show
Series linux-user: implement execveat | expand

Message

Philippe Mathieu-Daudé Nov. 4, 2022, 5:36 p.m. UTC 
As I was reviewing this patch from Drew:
https://lore.kernel.org/qemu-devel/20221104081015.706009-1-sir@cmpwn.com/
and it was too big for my review standards, I split it into smaller
steps. Since the result can help the other reviewers, post it.

Since v4:
- Constify struct flags
- Split Drew's patch in 4

Drew DeVault (4):
  linux-user/strace: Extract print_execve_argv() from print_execve()
  linux-user/strace: Add output for execveat() syscall
  linux-user/syscall: Extract do_execve() from do_syscall1()
  linux-user/syscall: Implement execveat()

Philippe Mathieu-Daudé (1):
  linux-user/strace: Constify struct flags

 linux-user/strace.c    | 134 +++++++++++++++----------
 linux-user/strace.list |   2 +-
 linux-user/syscall.c   | 216 ++++++++++++++++++++++-------------------
 3 files changed, 201 insertions(+), 151 deletions(-)

Comments

Laurent Vivier Jan. 25, 2023, 9:46 a.m. UTC | #1 
Le 04/11/2022 à 18:36, Philippe Mathieu-Daudé a écrit :
> As I was reviewing this patch from Drew:
> https://lore.kernel.org/qemu-devel/20221104081015.706009-1-sir@cmpwn.com/
> and it was too big for my review standards, I split it into smaller
> steps. Since the result can help the other reviewers, post it.
> 
> Since v4:
> - Constify struct flags
> - Split Drew's patch in 4
> 
> Drew DeVault (4):
>    linux-user/strace: Extract print_execve_argv() from print_execve()
>    linux-user/strace: Add output for execveat() syscall
>    linux-user/syscall: Extract do_execve() from do_syscall1()
>    linux-user/syscall: Implement execveat()
> 
> Philippe Mathieu-Daudé (1):
>    linux-user/strace: Constify struct flags
> 
>   linux-user/strace.c    | 134 +++++++++++++++----------
>   linux-user/strace.list |   2 +-
>   linux-user/syscall.c   | 216 ++++++++++++++++++++++-------------------
>   3 files changed, 201 insertions(+), 151 deletions(-)
> 

Applied to my linux-user-for-8.0 branch.

Thanks,
Laurent
Drew DeVault Jan. 25, 2023, 9:47 a.m. UTC | #2 
On Wed Jan 25, 2023 at 10:46 AM CET, Laurent Vivier wrote:
> Applied to my linux-user-for-8.0 branch.

Thanks!