[v2,1/5] dt-bindings: bluetooth: marvell: add 88W8997

Commit Message

Francesco Dolcini Jan. 26, 2023, 7:43 a.m. UTC

From: Stefan Eichenberger <[e-mail]>

Update the documentation with the device tree binding for the Marvell
88W8997 bluetooth device.

Signed-off-by: Stefan Eichenberger <[e-mail]>
Acked-by: Krzysztof Kozlowski <[e-mail]>
Signed-off-by: Francesco Dolcini <[e-mail]>
---
v2:
 - removed redundant "DT binding" from commit message title
 - add acked-by Krzysztof
---
 Documentation/devicetree/bindings/net/marvell-bluetooth.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

[e-mail] Jan. 26, 2023, 8:39 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=715765

---Test result---

Test Summary:
CheckPatch                    PASS      3.26 seconds
GitLint                       PASS      1.22 seconds
SubjectPrefix                 FAIL      0.69 seconds
BuildKernel                   PASS      37.71 seconds
CheckAllWarning               PASS      42.06 seconds
CheckSparse                   WARNING   46.99 seconds
CheckSmatch                   PASS      124.80 seconds
BuildKernel32                 PASS      37.73 seconds
TestRunnerSetup               PASS      524.78 seconds
TestRunner_l2cap-tester       PASS      19.56 seconds
TestRunner_iso-tester         PASS      21.01 seconds
TestRunner_bnep-tester        PASS      6.98 seconds
TestRunner_mgmt-tester        PASS      128.06 seconds
TestRunner_rfcomm-tester      PASS      10.71 seconds
TestRunner_sco-tester         PASS      9.93 seconds
TestRunner_ioctl-tester       PASS      11.95 seconds
TestRunner_mesh-tester        PASS      8.75 seconds
TestRunner_smp-tester         PASS      9.70 seconds
TestRunner_userchan-tester    PASS      7.45 seconds
IncrementalBuild              PASS      54.93 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer


---
Regards,
Linux Bluetooth

Francesco Dolcini Jan. 26, 2023, 3:13 p.m. UTC | #2

On Thu, Jan 26, 2023 at 12:39:44AM -0800, [e-mail] wrote:
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=715765
[snip]
> Test: SubjectPrefix - FAIL
> Desc: Check subject contains "Bluetooth" prefix
> Output:
> "Bluetooth: " prefix is not specified in the subject
> "Bluetooth: " prefix is not specified in the subject
> "Bluetooth: " prefix is not specified in the subject

These warning are bogus, the reason is that the series include a couple
dts/binding changes that have a different rule on the commit message
prefix.

> ##############################
> Test: CheckSparse - WARNING
> Desc: Run sparse tool with linux kernel
> Output:
> drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer
This sparse warning was not introduced by this series.

Francesco

Luiz Augusto von Dentz Jan. 26, 2023, 8:59 p.m. UTC | #3

Hi Francesco,

On Thu, Jan 26, 2023 at 7:15 AM Francesco Dolcini <[e-mail]> wrote:
>
> On Thu, Jan 26, 2023 at 12:39:44AM -0800, [e-mail] wrote:
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=715765
> [snip]
> > Test: SubjectPrefix - FAIL
> > Desc: Check subject contains "Bluetooth" prefix
> > Output:
> > "Bluetooth: " prefix is not specified in the subject
> > "Bluetooth: " prefix is not specified in the subject
> > "Bluetooth: " prefix is not specified in the subject
>
> These warning are bogus, the reason is that the series include a couple
> dts/binding changes that have a different rule on the commit message
> prefix.

Or CI only expects patches to Bluetooth subsystem or drivers, so
perhaps the dt-bindings changes shouldn't actually be send here if
there are not meant to be applied to bluetooth-next? Or we need some
sort of smart filtering so PW don't assume everything sent to
linux-bluetooth shall be tested by our CI.

> > ##############################
> > Test: CheckSparse - WARNING
> > Desc: Run sparse tool with linux kernel
> > Output:
> > drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integerdrivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer
> This sparse warning was not introduced by this series.

Yep, that is why they are treated as warnings not errors, still it
would be a good idea to fix those to avoid it popping up again.

> Francesco
>

Francesco Dolcini Jan. 27, 2023, 9:30 a.m. UTC | #4

Hello Luiz,

On Thu, Jan 26, 2023 at 12:59:36PM -0800, Luiz Augusto von Dentz wrote:
> On Thu, Jan 26, 2023 at 7:15 AM Francesco Dolcini <[e-mail]> wrote:
> > On Thu, Jan 26, 2023 at 12:39:44AM -0800, [e-mail] wrote:
> > > Thank you for submitting the patches to the linux bluetooth mailing list.
> > > This is a CI test results with your patch series:
> > > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=715765
> > [snip]
> > > Test: SubjectPrefix - FAIL
> > > Desc: Check subject contains "Bluetooth" prefix
> > > Output:
> > > "Bluetooth: " prefix is not specified in the subject
> > > "Bluetooth: " prefix is not specified in the subject
> > > "Bluetooth: " prefix is not specified in the subject
> >
> > These warning are bogus, the reason is that the series include a couple
> > dts/binding changes that have a different rule on the commit message
> > prefix.
> 
> Or CI only expects patches to Bluetooth subsystem or drivers, so
> perhaps the dt-bindings changes shouldn't actually be send here if
> there are not meant to be applied to bluetooth-next? Or we need some
From what I saw bindings changes
(Documentation/devicetree/bindings/net/) on bluetooth goes through you
once they are acked by the DT maintainer.

Last patch ([PATCH v2 5/5] arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4)
needs to go through Shawn and the SOC/i.MX tree, but it makes sense to
have it part of this whole series (at least to me). No reason to apply
it until the rest of the series is deemed fine.

Anyway, all good from my point of view, I replied to the CI email just
to let people know that I checked at the CI results and I believe is
all good on the series on this regard, not planning any change because
of it and that IMO it should not be a reason to hold on any review.
Just speak-up if I'm wrong here :-)

Thanks,
Francesco

Patch

diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
index 309ef21a1e37..83b64ed730f5 100644
--- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml
@@ -15,7 +15,9 @@  maintainers:
 
 properties:
   compatible:
-    const: mrvl,88w8897
+    enum:
+      - mrvl,88w8897
+      - mrvl,88w8997
 
 required:
   - compatible