| Message ID | 20230129154005.1567160-1-j.neuschaefer@gmx.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net: tulip: Fix a typo ("defualt") | expand |
On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote: > Spell it as "default". > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Looks good :) There also seems to be a misspelling of heartbeat (as hearbeat) on line 277. Perhaps it would be good to fix that at the same time? > --- > drivers/net/ethernet/dec/tulip/tulip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h > index 0ed598dc7569c..0aed3a1d8fe4b 100644 > --- a/drivers/net/ethernet/dec/tulip/tulip.h > +++ b/drivers/net/ethernet/dec/tulip/tulip.h > @@ -250,7 +250,7 @@ enum t21143_csr6_bits { > csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */ > csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */ > csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */ > - csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */ > + csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */ > csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */ > csr6_trh = (1<<15), /* Transmit Threshold high bit */ > csr6_trl = (1<<14), /* Transmit Threshold low bit */ > -- > 2.39.0 >
On Sun, Jan 29, 2023 at 07:35:15PM +0100, Simon Horman wrote: > On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote: > > Spell it as "default". > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Looks good :) > > There also seems to be a misspelling of heartbeat (as hearbeat) on line 277. > Perhaps it would be good to fix that at the same time? Sounds good, I'll spin a v2. Jonathan
diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h index 0ed598dc7569c..0aed3a1d8fe4b 100644 --- a/drivers/net/ethernet/dec/tulip/tulip.h +++ b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum t21143_csr6_bits { csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */ csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */ csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */ - csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */ + csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */ csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */ csr6_trh = (1<<15), /* Transmit Threshold high bit */ csr6_trl = (1<<14), /* Transmit Threshold low bit */
Spell it as "default". Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- drivers/net/ethernet/dec/tulip/tulip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.0