diff mbox series

monitor/att: Fix Set Member Lock decoding

Message ID 20230130091336.19098-1-marcin.kraglak@telink-semi.com (mailing list archive)
State Accepted
Commit f367fa3c9fe591792f124db2c9d81b61f296afdf
Headers show
Series monitor/att: Fix Set Member Lock decoding | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch warning CheckSparse WARNING monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Marcin Kraglak Jan. 30, 2023, 9:13 a.m. UTC
According to CSIS specification v1.0.1: "Allowed values for the Set
Member Lock characteristic are Unlocked (corresponding to the
numeric value 0x01) and Locked (corresponding to the numeric
value 0x02); all other values are RFU".
---
 monitor/att.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com Jan. 30, 2023, 10:55 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=716824

---Test result---

Test Summary:
CheckPatch                    PASS      0.75 seconds
GitLint                       PASS      0.30 seconds
BuildEll                      PASS      35.55 seconds
BluezMake                     PASS      1167.50 seconds
MakeCheck                     PASS      13.44 seconds
MakeDistcheck                 PASS      191.67 seconds
CheckValgrind                 PASS      314.94 seconds
CheckSmatch                   WARNING   434.30 seconds
bluezmakeextell               PASS      127.17 seconds
IncrementalBuild              PASS      970.60 seconds
ScanBuild                     PASS      1386.96 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.


---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Jan. 30, 2023, 9:40 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 30 Jan 2023 10:13:36 +0100 you wrote:
> According to CSIS specification v1.0.1: "Allowed values for the Set
> Member Lock characteristic are Unlocked (corresponding to the
> numeric value 0x01) and Locked (corresponding to the numeric
> value 0x02); all other values are RFU".
> ---
>  monitor/att.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - monitor/att: Fix Set Member Lock decoding
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f367fa3c9fe5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/monitor/att.c b/monitor/att.c
index 3b78884bc..05784e9f4 100644
--- a/monitor/att.c
+++ b/monitor/att.c
@@ -1760,10 +1760,10 @@  static void csip_lock_read(const struct l2cap_frame *frame)
 
 	switch (lock) {
 	case 0x01:
-		print_field("    Locked (0x%02x)", lock);
+		print_field("    Unlocked (0x%02x)", lock);
 		break;
 	case 0x02:
-		print_field("    Unlocked (0x%02x)", lock);
+		print_field("    Locked (0x%02x)", lock);
 		break;
 	default:
 		print_field("    RFU (0x%02x)", lock);