| Message ID | 20230130135555.3268172-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | clk: qcom: gcc-qcs404: fix duplicate initializer warning | expand |
On 30.01.2023 14:55, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > In one of the clocks, a redundant initialization for .num_parents > got left behind by a recent patch: > > drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init] > 63 | .num_parents = 1, > | ^ > > Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/clk/qcom/gcc-qcs404.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c > index 5f58dd82d3fe..a39c4990b29d 100644 > --- a/drivers/clk/qcom/gcc-qcs404.c > +++ b/drivers/clk/qcom/gcc-qcs404.c > @@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = { > .name = "cxo", > .parent_data = gcc_parent_data_1, > .num_parents = ARRAY_SIZE(gcc_parent_data_1), > - .num_parents = 1, > .ops = &clk_fixed_factor_ops, > }, > };
Quoting Arnd Bergmann (2023-01-30 05:55:47) > From: Arnd Bergmann <arnd@arndb.de> > > In one of the clocks, a redundant initialization for .num_parents > got left behind by a recent patch: > > drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init] > 63 | .num_parents = 1, > | ^ > > Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- This is https://lore.kernel.org/r/20230123201812.1230039-2-krzysztof.kozlowski@linaro.org
On Mon, 30 Jan 2023 14:55:47 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > In one of the clocks, a redundant initialization for .num_parents > got left behind by a recent patch: > > drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init] > 63 | .num_parents = 1, > | ^ > > [...] Applied, thanks! [1/1] clk: qcom: gcc-qcs404: fix duplicate initializer warning commit: d4cb3e7113f82f7378527890aa7b4006234665fe Best regards,
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c index 5f58dd82d3fe..a39c4990b29d 100644 --- a/drivers/clk/qcom/gcc-qcs404.c +++ b/drivers/clk/qcom/gcc-qcs404.c @@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = { .name = "cxo", .parent_data = gcc_parent_data_1, .num_parents = ARRAY_SIZE(gcc_parent_data_1), - .num_parents = 1, .ops = &clk_fixed_factor_ops, }, };