| Message ID | 20230202145208.2328032-5-quic_kathirav@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add APSS clock driver support for IPQ5332 | expand |
On 02/02/2023 15:52, Kathiravan T wrote: > Add the mailbox compatible for the IPQ5332 SoC. > > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 943f9472ae10..8d8cd1bbe67e 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -18,6 +18,7 @@ properties: > oneOf: - items: - enum: - qcom,ipq5332-apcs-apps-global - const: qcom,ipq6018-apcs-apps-global and drop the next patch Best regards, Krzysztof
On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Thanks, will update in V2, as suggested. > > > Best regards, > Krzysztof >
On 02/02/2023 17:35, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Is it still ok even if the two devices are not fully compatible (iow, using different PLL types)?
On 02/02/2023 22:00, Dmitry Baryshkov wrote: > On 02/02/2023 17:35, Krzysztof Kozlowski wrote: >> On 02/02/2023 15:52, Kathiravan T wrote: >>> Add the mailbox compatible for the IPQ5332 SoC. >>> >>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >>> --- >>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> index 943f9472ae10..8d8cd1bbe67e 100644 >>> --- >>> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> +++ >>> b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> @@ -18,6 +18,7 @@ properties: >>> oneOf: >> >> - items: >> - enum: >> - qcom,ipq5332-apcs-apps-global >> - const: qcom,ipq6018-apcs-apps-global >> >> and drop the next patch > > Is it still ok even if the two devices are not fully compatible (iow, > using different PLL types)? Ignore my question, I mixed the A53 and APCS clocks.
On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Hi Krzysztof, I'm planning to post the V2 of this series. How do you want me to proceed? I see you posted separate series[1]. May be I can follow the suggestion which you shared above, starting with IPQ? [1] https://lore.kernel.org/linux-arm-msm/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/ Thanks, > > > Best regards, > Krzysztof >
On 06/02/2023 10:12, Kathiravan T wrote: > > On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: >> On 02/02/2023 15:52, Kathiravan T wrote: >>> Add the mailbox compatible for the IPQ5332 SoC. >>> >>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >>> --- >>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> index 943f9472ae10..8d8cd1bbe67e 100644 >>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> @@ -18,6 +18,7 @@ properties: >>> oneOf: >> - items: >> - enum: >> - qcom,ipq5332-apcs-apps-global >> - const: qcom,ipq6018-apcs-apps-global >> >> and drop the next patch > > > Hi Krzysztof, > > I'm planning to post the V2 of this series. How do you want me to > proceed? I see you posted separate series[1]. May be I can follow the > suggestion which you shared above, starting with IPQ? My series need rebasing on top of Dmitry's fixes, so I propose you just send patch working only for ipq6018, like I wrote above. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 943f9472ae10..8d8cd1bbe67e 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -18,6 +18,7 @@ properties: oneOf: - items: - enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - qcom,msm8976-apcs-kpss-global @@ -111,6 +112,7 @@ allOf: properties: compatible: enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global then: @@ -127,6 +129,7 @@ allOf: properties: compatible: enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global then:
Add the mailbox compatible for the IPQ5332 SoC. Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ 1 file changed, 3 insertions(+)