| Message ID | b5d065218265e79daa23f82bb84efc6a7ea120fc.1675461757.git.jpoimboe@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cpu,sched: Mark arch_cpu_idle_dead() __noreturn | expand |
Josh Poimboeuf <jpoimboe@kernel.org> writes: > start_secondary_resume() doesn't return. Annotate it as such. By > extension this also makes arch_cpu_idle_dead() noreturn. Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? Seems like it would be good documentation, even if it's not required once the generic prototype is __noreturn. But not a show-stopper. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers > diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h > index f63505d74932..cfd42ca8765c 100644 > --- a/arch/powerpc/include/asm/smp.h > +++ b/arch/powerpc/include/asm/smp.h > @@ -66,7 +66,7 @@ void start_secondary(void *unused); > extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); > extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); > extern void smp_send_debugger_break(void); > -extern void start_secondary_resume(void); > +extern void __noreturn start_secondary_resume(void); > extern void smp_generic_give_timebase(void); > extern void smp_generic_take_timebase(void); > > -- > 2.39.0
On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote: > Josh Poimboeuf <jpoimboe@kernel.org> writes: > > start_secondary_resume() doesn't return. Annotate it as such. By > > extension this also makes arch_cpu_idle_dead() noreturn. > > Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? > > Seems like it would be good documentation, even if it's not required > once the generic prototype is __noreturn. Yeah, agreed. Maybe I'll do that (for all the implementations) with patch 22. > But not a show-stopper. > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Thanks!
diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h index f63505d74932..cfd42ca8765c 100644 --- a/arch/powerpc/include/asm/smp.h +++ b/arch/powerpc/include/asm/smp.h @@ -66,7 +66,7 @@ void start_secondary(void *unused); extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); extern void smp_send_debugger_break(void); -extern void start_secondary_resume(void); +extern void __noreturn start_secondary_resume(void); extern void smp_generic_give_timebase(void); extern void smp_generic_take_timebase(void);
start_secondary_resume() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> --- arch/powerpc/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)