| Message ID | Y+EHjQ0+QCAXxmlh@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 983272a2a223de59dbb4cb189aa4d02d7156d209 |
| Headers | show |
| Series | ASoC: codecs: aw88395: Uninitialized variable bug in aw_dev_parse_dev_type_v1() | expand |
On Mon, Feb 06, 2023 at 04:58:37PM +0300, Dan Carpenter wrote: > The "cur_scene_id" variable is never initialized. It needs to be set > to zero for the code to work. Someone already sent a fix for this.
diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c index 64dde972f3f0..d7c31a202adc 100644 --- a/sound/soc/codecs/aw88395/aw88395_lib.c +++ b/sound/soc/codecs/aw88395/aw88395_lib.c @@ -769,7 +769,7 @@ static int aw_dev_parse_dev_type_v1(struct aw_device *aw_dev, { struct aw_cfg_dde_v1 *cfg_dde = (struct aw_cfg_dde_v1 *)((char *)prof_hdr + prof_hdr->hdr_offset); - int cur_scene_id; + int cur_scene_id = 0; unsigned int i; int ret;
The "cur_scene_id" variable is never initialized. It needs to be set to zero for the code to work. Fixes: 4345865b003b ("ASoC: codecs: ACF bin parsing and check library file for aw88395") Signed-off-by: Dan Carpenter <error27@gmail.com> --- Presumably this code was tested with CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO=y or whatever to automatically initialize it to zero or it would have died specatularly. ;) sound/soc/codecs/aw88395/aw88395_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)