| Message ID | 20230205145245.11078-4-cheskaqiqi@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | modernize style | expand |
On Sun, Feb 5, 2023 at 9:56 AM Shuqi Liang <cheskaqiqi@gmail.com> wrote: > t4113: indent with space This probably ought to say "indent with tab" since that's what this patch is doing. > As Documentation/CodingGuidelines says, the shell scripts > are to use tabs for indentation, but this script > uses 4-column indent with space. Fix it in use tabs for indentation. s/in use/to use/ > Signed-off-by: Shuqi Liang <cheskaqiqi@gmail.com> > --- > diff --git a/t/t4113-apply-ending.sh b/t/t4113-apply-ending.sh > index e0a52a12c4..ab5ecaab7f 100755 > --- a/t/t4113-apply-ending.sh > +++ b/t/t4113-apply-ending.sh > @@ -22,11 +22,11 @@ test_expect_success setup ' > echo 'a' >file > echo 'b' >>file > echo 'c' >>file > - git update-index --add file > + git update-index --add file > ' As a GSoC microproject, v3 is probably "good enough", so there may not be a compelling reason to re-roll. If you do find a reason to re-roll, though, I might suggest swapping patches 2 and 3 since the current organization leaves a mix of tab and space indentation in the tests, which makes reviewers do extra work since they have to look ahead in the patch series to see if you fix the inconsistent indentation in a later patch.
Hi, Eric On Sun, Feb 5, 2023 at 3:30 PM Eric Sunshine <sunshine@sunshineco.com> wrote: > This probably ought to say "indent with tab" since that's what this > patch is doing. Thanks ,I will fix it . > If you do find a reason to re-roll, though, I might suggest swapping > patches 2 and 3 since the current organization leaves a mix of tab and > space indentation in the tests, which makes reviewers do extra work > since they have to look ahead in the patch series to see if you fix > the inconsistent indentation in a later patch. Yeah ,I didn‘t realize that .Thanks for reply! I will send the V4 soon. ---------- Thanks, Shuqi
diff --git a/t/t4113-apply-ending.sh b/t/t4113-apply-ending.sh index e0a52a12c4..ab5ecaab7f 100755 --- a/t/t4113-apply-ending.sh +++ b/t/t4113-apply-ending.sh @@ -22,11 +22,11 @@ test_expect_success setup ' echo 'a' >file echo 'b' >>file echo 'c' >>file - git update-index --add file + git update-index --add file ' test_expect_success 'apply at the end' ' - test_must_fail git apply --index test-patch + test_must_fail git apply --index test-patch ' test_expect_success 'apply at the beginning' ' @@ -44,7 +44,7 @@ test_expect_success 'apply at the beginning' ' b c' git update-index file - test_must_fail git apply --index test-patch + test_must_fail git apply --index test-patch ' test_done
As Documentation/CodingGuidelines says, the shell scripts are to use tabs for indentation, but this script uses 4-column indent with space. Fix it in use tabs for indentation. Signed-off-by: Shuqi Liang <cheskaqiqi@gmail.com> --- t/t4113-apply-ending.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)