| Message ID | a8aedc0f9a4c1e21d61694589c5b7a9f31cbedc1.1675103676.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [BlueZ,1/8] doc: add MGMT setting for CIS features, remove Quality Report | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '0454e2d09570', maybe rebased or not pulled? #99: commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), /github/workspace/src/src/13121669.patch total: 0 errors, 1 warnings, 18 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13121669.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 15: B2 Line has trailing whitespace: " " |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1799:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=717083
---Test result---
Test Summary:
CheckPatch FAIL 2.20 seconds
GitLint FAIL 1.53 seconds
BuildEll PASS 27.04 seconds
BluezMake PASS 745.55 seconds
MakeCheck PASS 11.00 seconds
MakeDistcheck PASS 146.65 seconds
CheckValgrind PASS 238.51 seconds
CheckSmatch WARNING 317.34 seconds
bluezmakeextell PASS 95.56 seconds
IncrementalBuild PASS 3050.31 seconds
ScanBuild PASS 938.84 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/8] doc: add MGMT setting for CIS features, remove Quality Report
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '0454e2d09570', maybe rebased or not pulled?
#99:
commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"),
/github/workspace/src/src/13121669.patch total: 0 errors, 1 warnings, 18 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13121669.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,1/8] doc: add MGMT setting for CIS features, remove Quality Report
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
15: B2 Line has trailing whitespace: " "
[BlueZ,4/8] tools/btmgmt: add names for MGMT setting bits for CIS feature support
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (81>80): "[BlueZ,4/8] tools/btmgmt: add names for MGMT setting bits for CIS feature support"
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1799:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures
---
Regards,
Linux Bluetooth
Hi Pauli, On Mon, Jan 30, 2023 at 10:43 AM Pauli Virtanen <pav@iki.fi> wrote: > > Add definitions for new MGMT Controller Information settings bits, > indicating adapter Connected Isochronous Stream - Central/Peripheral > feature support. > > The Set Quality Report command was removed in > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > but the settings bit was not removed. It's also not implemented on > kernel side, so remove it now. Let's split this into 2 patches, one removing Quality Report, since it was never implemented, and then another including the new flags. > --- > > Notes: > Was the quality report setting bit reserved on purpose? > > From the commit log it looks like it was forgotten to remove from the > docs, but this is not clear. > > doc/mgmt-api.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index 90d612ed8..58395dc90 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -332,7 +332,8 @@ Read Controller Information Command > 15 Static Address > 16 PHY Configuration > 17 Wideband Speech > - 18 Quality Report > + 18 Connected Isochronous Stream - Central > + 19 Connected Isochronous Stream - Peripheral > > This command generates a Command Complete event on success or > a Command Status event on failure. > @@ -2925,7 +2926,8 @@ Read Extended Controller Information Command > 15 Static Address > 16 PHY Configuration > 17 Wideband Speech > - 18 Quality Report > + 18 Connected Isochronous Stream - Central > + 19 Connected Isochronous Stream - Peripheral > > The EIR_Data field contains information about class of device, > local name and other values. Not all of them might be present. For > -- > 2.39.1 >
Hi Pauli, On Mon, Feb 6, 2023 at 5:08 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Pauli, > > On Mon, Jan 30, 2023 at 10:43 AM Pauli Virtanen <pav@iki.fi> wrote: > > > > Add definitions for new MGMT Controller Information settings bits, > > indicating adapter Connected Isochronous Stream - Central/Peripheral > > feature support. > > > > The Set Quality Report command was removed in > > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > > but the settings bit was not removed. It's also not implemented on > > kernel side, so remove it now. > > Let's split this into 2 patches, one removing Quality Report, since it > was never implemented, and then another including the new flags. Are you still planning on updating this set? > > --- > > > > Notes: > > Was the quality report setting bit reserved on purpose? > > > > From the commit log it looks like it was forgotten to remove from the > > docs, but this is not clear. > > > > doc/mgmt-api.txt | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > > index 90d612ed8..58395dc90 100644 > > --- a/doc/mgmt-api.txt > > +++ b/doc/mgmt-api.txt > > @@ -332,7 +332,8 @@ Read Controller Information Command > > 15 Static Address > > 16 PHY Configuration > > 17 Wideband Speech > > - 18 Quality Report > > + 18 Connected Isochronous Stream - Central > > + 19 Connected Isochronous Stream - Peripheral > > > > This command generates a Command Complete event on success or > > a Command Status event on failure. > > @@ -2925,7 +2926,8 @@ Read Extended Controller Information Command > > 15 Static Address > > 16 PHY Configuration > > 17 Wideband Speech > > - 18 Quality Report > > + 18 Connected Isochronous Stream - Central > > + 19 Connected Isochronous Stream - Peripheral > > > > The EIR_Data field contains information about class of device, > > local name and other values. Not all of them might be present. For > > -- > > 2.39.1 > > > > > -- > Luiz Augusto von Dentz
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 30 Jan 2023 20:37:32 +0200 you wrote: > Add definitions for new MGMT Controller Information settings bits, > indicating adapter Connected Isochronous Stream - Central/Peripheral > feature support. > > The Set Quality Report command was removed in > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > but the settings bit was not removed. It's also not implemented on > kernel side, so remove it now. > > [...] Here is the summary with links: - [BlueZ,1/8] doc: add MGMT setting for CIS features, remove Quality Report (no matching commit) - [BlueZ,2/8] lib: Add defines for MGMT setting bits for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35d32b19989 - [BlueZ,3/8] monitor: add names for MGMT setting bits for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f2f7a8fe270 - [BlueZ,4/8] tools/btmgmt: add names for MGMT setting bits for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f131929b832 - [BlueZ,5/8] adapter: add functions indicating adapter CIS capability (no matching commit) - [BlueZ,6/8] media: Check adapter CIS support to add BAP in SupportedUUIDs (no matching commit) - [BlueZ,7/8] shared/bap: handle central-only case (no matching commit) - [BlueZ,8/8] bap: handle adapters that are not CIS Central / Peripheral capable (no matching commit) You are awesome, thank you!
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 90d612ed8..58395dc90 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -332,7 +332,8 @@ Read Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report + 18 Connected Isochronous Stream - Central + 19 Connected Isochronous Stream - Peripheral This command generates a Command Complete event on success or a Command Status event on failure. @@ -2925,7 +2926,8 @@ Read Extended Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report + 18 Connected Isochronous Stream - Central + 19 Connected Isochronous Stream - Peripheral The EIR_Data field contains information about class of device, local name and other values. Not all of them might be present. For
Add definitions for new MGMT Controller Information settings bits, indicating adapter Connected Isochronous Stream - Central/Peripheral feature support. The Set Quality Report command was removed in commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), but the settings bit was not removed. It's also not implemented on kernel side, so remove it now. --- Notes: Was the quality report setting bit reserved on purpose? From the commit log it looks like it was forgotten to remove from the docs, but this is not clear. doc/mgmt-api.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)