| Message ID | 20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e42af72223fdd0a4eca49e1bb904856710fdd46c |
| Headers | show |
| Series | firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries | expand |
On Tue, Feb 7, 2023 at 8:12 AM Douglas Anderson <dianders@chromium.org> wrote: > > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > > drivers/firmware/google/Kconfig | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig > index 9f190eab43ed..1bc7cbf2f65d 100644 > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE > device tree node /firmware/coreboot. > If unsure say N. > > -config GOOGLE_COREBOOT_TABLE_ACPI > - tristate > - select GOOGLE_COREBOOT_TABLE > - > -config GOOGLE_COREBOOT_TABLE_OF > - tristate > - select GOOGLE_COREBOOT_TABLE > - > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT > -- > 2.39.1.519.gcb327c4b5f-goog >
On 2023-02-07 at 08:12 -0800, Douglas Anderson wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> > --- > > drivers/firmware/google/Kconfig | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig > index 9f190eab43ed..1bc7cbf2f65d 100644 > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE > device tree node /firmware/coreboot. > If unsure say N. > > -config GOOGLE_COREBOOT_TABLE_ACPI > - tristate > - select GOOGLE_COREBOOT_TABLE > - > -config GOOGLE_COREBOOT_TABLE_OF > - tristate > - select GOOGLE_COREBOOT_TABLE > - > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT > -- > 2.39.1.519.gcb327c4b5f-goog >
Quoting Douglas Anderson (2023-02-07 08:12:00) > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Acked-by: Stephen Boyd <swboyd@chromium.org>
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Greg Kroah-Hartman <gregkh@linuxfoundation.org>: On Tue, 7 Feb 2023 08:12:00 -0800 you wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > [...] Here is the summary with links: - firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries https://git.kernel.org/chrome-platform/c/e42af72223fd You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Greg Kroah-Hartman <gregkh@linuxfoundation.org>: On Tue, 7 Feb 2023 08:12:00 -0800 you wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > [...] Here is the summary with links: - firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries https://git.kernel.org/chrome-platform/c/e42af72223fd You are awesome, thank you!
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig index 9f190eab43ed..1bc7cbf2f65d 100644 --- a/drivers/firmware/google/Kconfig +++ b/drivers/firmware/google/Kconfig @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE device tree node /firmware/coreboot. If unsure say N. -config GOOGLE_COREBOOT_TABLE_ACPI - tristate - select GOOGLE_COREBOOT_TABLE - -config GOOGLE_COREBOOT_TABLE_OF - tristate - select GOOGLE_COREBOOT_TABLE - config GOOGLE_MEMCONSOLE tristate depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" text and thus aren't user choosable. They also aren't "select"ed by anything. They also control the compilation of no code. Let's remove them. Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/firmware/google/Kconfig | 8 -------- 1 file changed, 8 deletions(-)