| Message ID | 20230208042850.1687-5-quic_kathirav@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add APSS clock driver support for IPQ5332 | expand |
On 08/02/2023 05:28, Kathiravan T wrote: > Add the mailbox compatible for the IPQ5332 SoC. > > Since the IPQ5332 mailbox is compatible with the IPQ6018, lets create the > fallback to ipq6018 compatible, so that we don't bloat the of_device_id > table in the driver. > > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 943f9472ae10..a65b61e5acb0 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -16,6 +16,10 @@ maintainers: properties: compatible: oneOf: + - items: + - enum: + - qcom,ipq5332-apcs-apps-global + - const: qcom,ipq6018-apcs-apps-global - items: - enum: - qcom,ipq6018-apcs-apps-global @@ -110,9 +114,10 @@ allOf: - if: properties: compatible: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global + contains: + enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global then: properties: clocks: @@ -126,9 +131,10 @@ allOf: - if: properties: compatible: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global + contains: + enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global then: properties: '#clock-cells':
Add the mailbox compatible for the IPQ5332 SoC. Since the IPQ5332 mailbox is compatible with the IPQ6018, lets create the fallback to ipq6018 compatible, so that we don't bloat the of_device_id table in the driver. Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> --- Changes in V2: - As suggested by Krzysztof, modified the binding to use the fallback mechanism so that we don't keep adding the compatibles with the same driver data in mailbox driver .../mailbox/qcom,apcs-kpss-global.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)