diff mbox series

dt-bindings: phy: amlogic,g12a-usb3-pcie-phy: add missing optional phy-supply property

Message ID 20230207-b4-amlogic-amlogic-g12a-usb3-pcie-phy-fix-v1-1-3e437b759549@linaro.org
State Accepted
Commit a9b444988026528788c83c995ebb44eda5a54d8c
Headers show
Series dt-bindings: phy: amlogic,g12a-usb3-pcie-phy: add missing optional phy-supply property | expand

Commit Message

Neil Armstrong Feb. 7, 2023, 3:03 p.m. UTC
Add missing optional phy-supply property used to power up PHY regulators.

Fixes: 87a55485f2fc ("dt-bindings: phy: meson-g12a-usb3-pcie-phy: convert to yaml")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 .../devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml          | 5 +++++
 1 file changed, 5 insertions(+)


---
base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
change-id: 20230207-b4-amlogic-amlogic-g12a-usb3-pcie-phy-fix-b5daf54fb7d6

Best regards,

Comments

Rob Herring (Arm) Feb. 8, 2023, 11:46 p.m. UTC | #1
On Tue, 07 Feb 2023 16:03:53 +0100, Neil Armstrong wrote:
> Add missing optional phy-supply property used to power up PHY regulators.
> 
> Fixes: 87a55485f2fc ("dt-bindings: phy: meson-g12a-usb3-pcie-phy: convert to yaml")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml          | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Vinod Koul Feb. 10, 2023, 5:07 p.m. UTC | #2
On 07-02-23, 16:03, Neil Armstrong wrote:
> Add missing optional phy-supply property used to power up PHY regulators.
> 
> Fixes: 87a55485f2fc ("dt-bindings: phy: meson-g12a-usb3-pcie-phy: convert to yaml")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml          | 5 +++++

I dont have this file in my tree, what was this based on?

>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
> index 129d26e99776..3314711292d6 100644
> --- a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
> @@ -35,6 +35,11 @@ properties:
>    "#phy-cells":
>      const: 1
>  
> +  phy-supply:
> +    description:
> +      Phandle to a regulator that provides power to the PHY. This
> +      regulator will be managed during the PHY power on/off sequence.
> +
>  required:
>    - compatible
>    - reg
> 
> ---
> base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
> change-id: 20230207-b4-amlogic-amlogic-g12a-usb3-pcie-phy-fix-b5daf54fb7d6
> 
> Best regards,
> -- 
> Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong Feb. 11, 2023, 1:49 p.m. UTC | #3
Le 10/02/2023 à 18:07, Vinod Koul a écrit :
> On 07-02-23, 16:03, Neil Armstrong wrote:
>> Add missing optional phy-supply property used to power up PHY regulators.
>>
>> Fixes: 87a55485f2fc ("dt-bindings: phy: meson-g12a-usb3-pcie-phy: convert to yaml")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   .../devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml          | 5 +++++
> 
> I dont have this file in my tree, what was this based on?

It has been renamed in a previous patch by Heiner: https://lore.kernel.org/all/8d960029-e94d-224b-911f-03e5deb47ebc@gmail.com/

Neil

> 
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
>> index 129d26e99776..3314711292d6 100644
>> --- a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
>> @@ -35,6 +35,11 @@ properties:
>>     "#phy-cells":
>>       const: 1
>>   
>> +  phy-supply:
>> +    description:
>> +      Phandle to a regulator that provides power to the PHY. This
>> +      regulator will be managed during the PHY power on/off sequence.
>> +
>>   required:
>>     - compatible
>>     - reg
>>
>> ---
>> base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
>> change-id: 20230207-b4-amlogic-amlogic-g12a-usb3-pcie-phy-fix-b5daf54fb7d6
>>
>> Best regards,
>> -- 
>> Neil Armstrong <neil.armstrong@linaro.org>
>
Vinod Koul Feb. 14, 2023, 1:57 p.m. UTC | #4
On 11-02-23, 14:49, Neil Armstrong wrote:
> Le 10/02/2023 à 18:07, Vinod Koul a écrit :
> > On 07-02-23, 16:03, Neil Armstrong wrote:
> > > Add missing optional phy-supply property used to power up PHY regulators.
> > > 
> > > Fixes: 87a55485f2fc ("dt-bindings: phy: meson-g12a-usb3-pcie-phy: convert to yaml")
> > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > ---
> > >   .../devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml          | 5 +++++
> > 
> > I dont have this file in my tree, what was this based on?
> 
> It has been renamed in a previous patch by Heiner: https://lore.kernel.org/all/8d960029-e94d-224b-911f-03e5deb47ebc@gmail.com/

Thanks for letting me know, I have merged fixes which had above and
applied this
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
index 129d26e99776..3314711292d6 100644
--- a/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-usb3-pcie-phy.yaml
@@ -35,6 +35,11 @@  properties:
   "#phy-cells":
     const: 1
 
+  phy-supply:
+    description:
+      Phandle to a regulator that provides power to the PHY. This
+      regulator will be managed during the PHY power on/off sequence.
+
 required:
   - compatible
   - reg