| Message ID | 1675700201-12890-6-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SC7280 audioreach device tree nodes | expand |
Quoting Srinivasa Rao Mandadapu (2023-02-06 08:16:38) > Update lpass_tlmm clock properties, as different clock sources > are required in ADSP enabled platforms. > Also update LPASS_MCC register region. This is required to avoid > memory region conflicts due to overlapping lpass_efuse Q6 regmap > region used in LPASS PIL node. If efuse is overlapping, why isn't that made into an nvmem device that can be used or not used depending on the configuration?
On 06/02/2023 17:16, Srinivasa Rao Mandadapu wrote: > Update lpass_tlmm clock properties, as different clock sources All your subjects are vague. Everything is "update". That's not acceptable subject. > are required in ADSP enabled platforms. > Also update LPASS_MCC register region. This is required to avoid > memory region conflicts due to overlapping lpass_efuse Q6 regmap > region used in LPASS PIL node. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Tested-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > --- > .../arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > index 9b04491..86ba4a5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > @@ -121,6 +121,15 @@ > status = "okay"; > }; > > +&lpass_tlmm { > + clocks = <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > + > + clock-names = "core", "audio"; > + reg = <0 0x033c0000 0x0 0x20000>, > + <0 0x03550000 0x0 0xa100>; Are you sure your patchset is bisectable? The conflict is already there - via patch #3 - isn't it? > +}; > + > &lpass_tx_macro { > /delete-property/ power-domains; > /delete-property/ power-domain-names; Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi index 9b04491..86ba4a5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi @@ -121,6 +121,15 @@ status = "okay"; }; +&lpass_tlmm { + clocks = <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; + + clock-names = "core", "audio"; + reg = <0 0x033c0000 0x0 0x20000>, + <0 0x03550000 0x0 0xa100>; +}; + &lpass_tx_macro { /delete-property/ power-domains; /delete-property/ power-domain-names;