| Message ID | Y+T4aoefc1XWvGYb@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 183514f7c569c462da45cc92a3843b666d588413 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: libwx: fix an error code in wx_alloc_page_pool() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 9 Feb 2023 16:43:06 +0300 you wrote: > This function always returns success. We need to preserve the error > code before setting rx_ring->page_pool = NULL. > > Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Applies to net-next. > > [...] Here is the summary with links: - [net-next] net: libwx: fix an error code in wx_alloc_page_pool() https://git.kernel.org/netdev/net-next/c/183514f7c569 You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c index 57e1871ea0c6..ca92fe19a663 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c @@ -1745,8 +1745,8 @@ static int wx_alloc_page_pool(struct wx_ring *rx_ring) rx_ring->page_pool = page_pool_create(&pp_params); if (IS_ERR(rx_ring->page_pool)) { - rx_ring->page_pool = NULL; ret = PTR_ERR(rx_ring->page_pool); + rx_ring->page_pool = NULL; } return ret;
This function always returns success. We need to preserve the error code before setting rx_ring->page_pool = NULL. Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources") Signed-off-by: Dan Carpenter <error27@gmail.com> --- Applies to net-next. drivers/net/ethernet/wangxun/libwx/wx_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)