| Message ID | 20230209095753.447347-3-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm: qcom: sa8775p: add socinfo support | expand |
On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add the SoC ID entry for SA8775P. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > include/dt-bindings/arm/qcom,ids.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Chanudet <echanude@redhat.com> Tested-by: Eric Chanudet <echanude@redhat.com>
On 09/02/2023 18:55, Eric Chanudet wrote: > On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> >> Add the SoC ID entry for SA8775P. >> >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> include/dt-bindings/arm/qcom,ids.h | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Eric Chanudet <echanude@redhat.com> > Tested-by: Eric Chanudet <echanude@redhat.com> How can you test a header? What type of testing Redhat does on the headers? Best regards, Krzysztof
On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote: > On 09/02/2023 18:55, Eric Chanudet wrote: > > On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote: > >> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >> > >> Add the SoC ID entry for SA8775P. > >> > >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> include/dt-bindings/arm/qcom,ids.h | 1 + > >> 1 file changed, 1 insertion(+) > > > > Reviewed-by: Eric Chanudet <echanude@redhat.com> > > Tested-by: Eric Chanudet <echanude@redhat.com> > > How can you test a header? What type of testing Redhat does on the headers? IIUC that ID is compared against the one read from SMEM by the socinfo driver. I meant to confirm it matched the number the board I have returned. My apologies in advance if that was inappropriate.
On 10/02/2023 15:52, Eric Chanudet wrote: > On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote: >> On 09/02/2023 18:55, Eric Chanudet wrote: >>> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote: >>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>> >>>> Add the SoC ID entry for SA8775P. >>>> >>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> include/dt-bindings/arm/qcom,ids.h | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> Reviewed-by: Eric Chanudet <echanude@redhat.com> >>> Tested-by: Eric Chanudet <echanude@redhat.com> >> >> How can you test a header? What type of testing Redhat does on the headers? > > IIUC that ID is compared against the one read from SMEM by the socinfo > driver. I meant to confirm it matched the number the board I have > returned. My apologies in advance if that was inappropriate. OK... I would say it is a review then, but can be also this way. Best regards, Krzysztof
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h index 22d7ba17804b..bfdf066cc690 100644 --- a/include/dt-bindings/arm/qcom,ids.h +++ b/include/dt-bindings/arm/qcom,ids.h @@ -223,6 +223,7 @@ #define QCOM_ID_SC7180P 495 #define QCOM_ID_SM6375 507 #define QCOM_ID_SM8550 519 +#define QCOM_ID_SA8775P 534 #define QCOM_ID_QRU1000 539 #define QCOM_ID_QDU1000 545 #define QCOM_ID_QDU1010 587